Extension window.create API accepts state.

chrome/browser/extensions/api/tabs/tabs_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
@@ skipping 23 matching lines @@
 #include "extensions/common/test_util.h"
 #include "net/test/spawned_test_server/spawned_test_server.h"
 #include "ui/gfx/geometry/rect.h"
 
 namespace extensions {
 
 namespace keys = tabs_constants;
 namespace utils = extension_function_test_utils;
 
 namespace {
-
-class ExtensionTabsTest : public InProcessBrowserTest {
-};
-
+using ExtensionTabsTest = InProcessBrowserTest;
+using ExtensionWindowCreateTest = InProcessBrowserTest;
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, GetWindow) {
   int window_id = ExtensionTabUtil::GetWindowId(browser());
 
   // Invalid window ID error.
   scoped_refptr<WindowsGetFunction> function = new WindowsGetFunction();
   scoped_refptr<Extension> extension(test_util::CreateEmptyExtension());
   function->set_extension(extension.get());
   EXPECT_TRUE(MatchPattern(
@@ skipping 499 matching lines @@
   function = new WindowsUpdateFunction();
   function->set_extension(extension.get());
   EXPECT_TRUE(MatchPattern(
       utils::RunFunctionAndReturnError(
           function.get(),
           base::StringPrintf(kArgsMaximizedWithBounds, window_id),
           browser()),
       keys::kInvalidWindowStateError));
 }
 
+IN_PROC_BROWSER_TEST_F(ExtensionWindowCreateTest, AcceptState) {
+  scoped_refptr<WindowsCreateFunction> function(new WindowsCreateFunction());
+  scoped_refptr<Extension> extension(test_util::CreateEmptyExtension());
+  function->set_extension(extension.get());
+
+  scoped_ptr<base::DictionaryValue> result(
+      utils::ToDictionary(utils::RunFunctionAndReturnSingleResult(
+          function.get(), "[{\"state\": \"fullscreen\"}]", browser(),
+          utils::INCLUDE_INCOGNITO)));
+  int window_id = api_test_utils::GetInteger(result.get(), "id");
+  std::string error;
+  Browser* new_window = ExtensionTabUtil::GetBrowserFromWindowID(
+      function.get(), window_id, &error);
+  EXPECT_TRUE(new_window->window()->IsFullscreen());
+  EXPECT_TRUE(error.empty());
+
+  function = new WindowsCreateFunction();
+  function->set_extension(extension.get());
+  result.reset(utils::ToDictionary(utils::RunFunctionAndReturnSingleResult(
+      function.get(), "[{\"state\": \"minimized\"}]", browser(),
+      utils::INCLUDE_INCOGNITO)));
+  window_id = api_test_utils::GetInteger(result.get(), "id");
+  new_window = ExtensionTabUtil::GetBrowserFromWindowID(function.get(),
+                                                        window_id, &error);
+  EXPECT_TRUE(error.empty());
+#if !defined(OS_LINUX) || defined(OS_CHROMEOS)

[not at google - send to devlin, 2015/04/17 16:49:47]

does defined(OS_CHROMEOS) not already imply !defined(OS_LINUX); my point being,
is !defined(OS_LINUX) not enough?

[limasdf, 2015/04/17 18:33:26]

This #if guard should NOT enabled for only 'Linux desktop'.

As you might know, For only Linux desktop, We use "OS_LINUX && !OS_CHROMEOS"
which is same with !OS_LINUX || OS_CHROME_OS by De Morgan's law.

If I take !defined(OS_LINUX), then this #if guard will not be enabled for Linux
Desktop and *Chrome OS. that's not what I intended.

+  // DesktopWindowTreeHostX11::IsMinimized() relies on an asynchronous update
+  // from the window server.
+  EXPECT_TRUE(new_window->window()->IsMinimized());
+#endif
+}
+
 IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DuplicateTab) {
   content::OpenURLParams params(GURL(url::kAboutBlankURL),
                                 content::Referrer(),
                                 NEW_FOREGROUND_TAB,
                                 ui::PAGE_TRANSITION_LINK,
                                 false);
   content::WebContents* web_contents = browser()->OpenURL(params);
   int tab_id = ExtensionTabUtil::GetTabId(web_contents);
   int window_id = ExtensionTabUtil::GetWindowIdOfTab(web_contents);
   int tab_index = -1;
@@ skipping 508 matching lines @@
   // Test chrome.tabs.setZoom().
   error = RunSetZoomExpectError(tab_id, 3.14159);
   EXPECT_TRUE(MatchPattern(error, manifest_errors::kCannotAccessChromeUrl));
 
   // chrome.tabs.setZoomSettings().
   error = RunSetZoomSettingsExpectError(tab_id, "manual", "per-tab");
   EXPECT_TRUE(MatchPattern(error, manifest_errors::kCannotAccessChromeUrl));
 }
 
 }  // namespace extensions