Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1015083002: convert last api functions which try to handle exceptions to maybes (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

convert last api functions which try to handle exceptions to maybes BUG=v8:3929 LOG=n Committed: https://crrev.com/7f38011a04ca27e8f88b300713c8dc05ba8d61d7 Cr-Commit-Position: refs/heads/master@{#27270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -53 lines) Patch
M include/v8.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/api.cc View 3 chunks +36 lines, -51 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sven Panne
lgtm
5 years, 9 months ago (2015-03-18 11:48:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015083002/1
5 years, 9 months ago (2015-03-18 12:00:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 12:50:18 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 12:50:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f38011a04ca27e8f88b300713c8dc05ba8d61d7
Cr-Commit-Position: refs/heads/master@{#27270}

Powered by Google App Engine
This is Rietveld 408576698