Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 101503003: Test for prefetch cache resetting on IDBObjectStore.clear() (Closed)

Created:
7 years ago by jsbell
Modified:
7 years ago
Reviewers:
dgrogan
CC:
blink-reviews, dgrogan, alecflett, jsbell, cmumford
Visibility:
Public.

Description

Test for prefetch cache resetting on IDBObjectStore.clear() Depends on crrev.com/116363006 on the Chromium side. BUG=329971 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164246

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -0 lines) Patch
A LayoutTests/storage/indexeddb/prefetch-invalidation.html View 1 chunk +90 lines, -0 lines 3 comments Download
A LayoutTests/storage/indexeddb/prefetch-invalidation-expected.txt View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jsbell
dgrogan@ - PTAL? Fix is over in https://codereview.chromium.org/116363006/
7 years ago (2013-12-19 19:59:00 UTC) #1
dgrogan
lgtm https://codereview.chromium.org/101503003/diff/1/LayoutTests/storage/indexeddb/prefetch-invalidation.html File LayoutTests/storage/indexeddb/prefetch-invalidation.html (right): https://codereview.chromium.org/101503003/diff/1/LayoutTests/storage/indexeddb/prefetch-invalidation.html#newcode34 LayoutTests/storage/indexeddb/prefetch-invalidation.html:34: }()); What's the advantage to the (function {...}()) ...
7 years ago (2013-12-19 21:53:05 UTC) #2
jsbell
https://codereview.chromium.org/101503003/diff/1/LayoutTests/storage/indexeddb/prefetch-invalidation.html File LayoutTests/storage/indexeddb/prefetch-invalidation.html (right): https://codereview.chromium.org/101503003/diff/1/LayoutTests/storage/indexeddb/prefetch-invalidation.html#newcode34 LayoutTests/storage/indexeddb/prefetch-invalidation.html:34: }()); On 2013/12/19 21:53:06, dgrogan wrote: > What's the ...
7 years ago (2013-12-19 22:04:24 UTC) #3
dgrogan
https://codereview.chromium.org/101503003/diff/1/LayoutTests/storage/indexeddb/prefetch-invalidation.html File LayoutTests/storage/indexeddb/prefetch-invalidation.html (right): https://codereview.chromium.org/101503003/diff/1/LayoutTests/storage/indexeddb/prefetch-invalidation.html#newcode34 LayoutTests/storage/indexeddb/prefetch-invalidation.html:34: }()); On 2013/12/19 22:04:25, jsbell wrote: > On 2013/12/19 ...
7 years ago (2013-12-19 23:00:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/101503003/1
7 years ago (2013-12-20 18:04:02 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-20 20:09:22 UTC) #6
Message was sent while issue was closed.
Change committed as 164246

Powered by Google App Engine
This is Rietveld 408576698