Test for prefetch cache resetting on IDBObjectStore.clear()

Test for prefetch cache resetting on IDBObjectStore.clear()

Depends on crrev.com/116363006 on the Chromium side.

BUG=329971
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164246

[jsbell, 2013-12-19 19:59:00]

dgrogan@ - PTAL?

Fix is over in https://codereview.chromium.org/116363006/

[dgrogan, 2013-12-19 21:53:05]

lgtm

https://codereview.chromium.org/101503003/diff/1/LayoutTests/storage/indexedd...
File LayoutTests/storage/indexeddb/prefetch-invalidation.html (right):

https://codereview.chromium.org/101503003/diff/1/LayoutTests/storage/indexedd...
LayoutTests/storage/indexeddb/prefetch-invalidation.html:34: }());
What's the advantage to the (function {...}()) pattern? I'd have thought it was
to keep nextStep out of the global namespace but being inside onOpenSuccess
seems to take care of that, no?

[jsbell, 2013-12-19 22:04:24]

https://codereview.chromium.org/101503003/diff/1/LayoutTests/storage/indexedd...
File LayoutTests/storage/indexeddb/prefetch-invalidation.html (right):

https://codereview.chromium.org/101503003/diff/1/LayoutTests/storage/indexedd...
LayoutTests/storage/indexeddb/prefetch-invalidation.html:34: }());
On 2013/12/19 21:53:06, dgrogan wrote:
> What's the advantage to the (function {...}()) pattern? I'd have thought it
was
> to keep nextStep out of the global namespace but being inside onOpenSuccess
> seems to take care of that, no?

Not quite it's not quite an IIFE
(http://en.wikipedia.org/wiki/Immediately-invoked_function_expression) - it's
also named so it can recurse. I could write it this way instead:

function nextStep() { ... }
nextStep();

Should I switch it?

[dgrogan, 2013-12-19 23:00:16]

https://codereview.chromium.org/101503003/diff/1/LayoutTests/storage/indexedd...
File LayoutTests/storage/indexeddb/prefetch-invalidation.html (right):

https://codereview.chromium.org/101503003/diff/1/LayoutTests/storage/indexedd...
LayoutTests/storage/indexeddb/prefetch-invalidation.html:34: }());
On 2013/12/19 22:04:25, jsbell wrote:
> On 2013/12/19 21:53:06, dgrogan wrote:
> > What's the advantage to the (function {...}()) pattern? I'd have thought it
> was
> > to keep nextStep out of the global namespace but being inside onOpenSuccess
> > seems to take care of that, no?
> 
> Not quite it's not quite an IIFE
> (http://en.wikipedia.org/wiki/Immediately-invoked_function_expression) - it's
> also named so it can recurse. I could write it this way instead:
> 
> function nextStep() { ... }
> nextStep();
> 
> Should I switch it?

No, it's fine.

[commit-bot: I haz the power, 2013-12-20 18:04:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/101503003/1

[commit-bot: I haz the power, 2013-12-20 20:09:22]

Change committed as 164246