Plugin Power Saver: Throttle 'large' plugins that appear small.

content/renderer/pepper/plugin_instance_throttler_impl.h

Index: content/renderer/pepper/plugin_instance_throttler_impl.h
diff --git a/content/renderer/pepper/plugin_instance_throttler_impl.h b/content/renderer/pepper/plugin_instance_throttler_impl.h
index 54f17cfff9bdae5ac0f868fa777ef378d5fe78d2..1a872b816a8d4b9e157fd142aa34b29f78579b9b 100644
--- a/content/renderer/pepper/plugin_instance_throttler_impl.h
+++ b/content/renderer/pepper/plugin_instance_throttler_impl.h
@@ -13,6 +13,7 @@
 #include "content/public/renderer/plugin_instance_throttler.h"
 #include "ppapi/shared_impl/ppb_view_shared.h"
 #include "third_party/skia/include/core/SkBitmap.h"
+#include "ui/gfx/geometry/size.h"
 
 namespace blink {
 class WebInputEvent;
@@ -38,6 +39,7 @@ class CONTENT_EXPORT PluginInstanceThrottlerImpl
   void MarkPluginEssential(PowerSaverUnthrottleMethod method) override;
   void SetHiddenForPlaceholder(bool hidden) override;
   blink::WebPlugin* GetWebPlugin() const override;
+  const gfx::Size& GetSize() const override;
   void NotifyAudioThrottled() override;
 
   void SetWebPlugin(blink::WebPlugin* web_plugin);
@@ -54,7 +56,7 @@ class CONTENT_EXPORT PluginInstanceThrottlerImpl
   void Initialize(RenderFrameImpl* frame,
                   const GURL& content_origin,
                   const std::string& plugin_module_name,
-                  const blink::WebRect& bounds);
+                  const gfx::Size& size);

[Lei Zhang, 2015/04/01 19:18:35]

The comment above still refers to view bounds, but you've renamed the variable.

[tommycli, 2015/04/01 19:33:20]

Done.

 
   // Called when the plugin flushes it's graphics context. Supplies the
   // throttler with a candidate to use as the representative keyframe.
@@ -99,6 +101,9 @@ class CONTENT_EXPORT PluginInstanceThrottlerImpl
   // Number of frames we've examined to find a keyframe.
   int frames_examined_;
 
+  // Plugin dimensions as of initialization.
+  gfx::Size initialized_size_;

[Lei Zhang, 2015/04/01 19:18:35]

const

[tommycli, 2015/04/01 19:33:20]

I cannot, as it's modified after the constructor.

+
   // Video plugins with throttled audio often stop generating frames.
   // This timer is so we don't wait forever for candidate poster frames.
   bool audio_throttled_;