Plugin Power Saver: Throttle 'large' plugins that appear small.

content/renderer/pepper/plugin_instance_throttler_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/plugin_instance_throttler_impl.h"
 
 #include "base/metrics/histogram.h"
 #include "base/time/time.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/renderer/render_thread.h"
@@ skipping 83 matching lines @@
 void PluginInstanceThrottlerImpl::SetHiddenForPlaceholder(bool hidden) {
   is_hidden_for_placeholder_ = hidden;
   FOR_EACH_OBSERVER(Observer, observer_list_, OnHiddenForPlaceholder(hidden));
 }
 
 blink::WebPlugin* PluginInstanceThrottlerImpl::GetWebPlugin() const {
   DCHECK(web_plugin_);
   return web_plugin_;
 }
 
+const gfx::Size& PluginInstanceThrottlerImpl::GetSize() const {
+  return initialized_size_;
+}
+
 void PluginInstanceThrottlerImpl::SetWebPlugin(blink::WebPlugin* web_plugin) {
   DCHECK(!web_plugin_);
   web_plugin_ = web_plugin;
 }
 
 void PluginInstanceThrottlerImpl::Initialize(
     RenderFrameImpl* frame,
     const GURL& content_origin,
     const std::string& plugin_module_name,
-    const blink::WebRect& bounds) {
+    const gfx::Size& size) {
+  initialized_size_ = size;

[Lei Zhang, 2015/03/18 00:48:12]

put this in the initializer list?

[tommycli, 2015/03/19 22:10:12]

I was not able to, as the Throttler is constructed way before Initialize(...) is
called.

[Lei Zhang, 2015/03/19 22:29:44]

Whoops, I was thinking this was the ctor. Ignore.

+
   // |frame| may be nullptr in tests.
   if (frame) {
     PluginPowerSaverHelper* helper = frame->plugin_power_saver_helper();
     bool cross_origin_main_content = false;
     if (!helper->ShouldThrottleContent(content_origin, plugin_module_name,
-                                       bounds.width, bounds.height,
+                                       size.width(), size.height(),
                                        &cross_origin_main_content)) {
       state_ = THROTTLER_STATE_MARKED_ESSENTIAL;
 
       if (cross_origin_main_content)
         helper->WhitelistContentOrigin(content_origin);
 
       return;
     }
 
     // To collect UMAs, register peripheral content even if power saver mode
@@ skipping 47 matching lines @@
 
 void PluginInstanceThrottlerImpl::EngageThrottle() {
   if (state_ != THROTTLER_STATE_AWAITING_KEYFRAME)
     return;
 
   state_ = THROTTLER_STATE_PLUGIN_THROTTLED;
   FOR_EACH_OBSERVER(Observer, observer_list_, OnThrottleStateChange());
 }
 
 }  // namespace content