[Extensions UI] Fix shared module view in chrome://extensions

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 ///////////////////////////////////////////////////////////////////////////////
 // ExtensionFocusRow:
 
 /**
@@ skipping 723 matching lines @@
       row.classList.toggle('developer-extras', hasDependents);
       this.updateVisibility_(row, '.dependent-extensions-message',
                              hasDependents, function(item) {
         var dependentList = item.querySelector('ul');
         dependentList.textContent = '';
         var dependentTemplate = $('template-collection').querySelector(
             '.dependent-list-item');
         extension.dependentExtensions.forEach(function(dependentId) {
           var dependentExtension = null;
           for (var i = 0; i < this.extensions_.length; ++i) {
             if (this.extensions_[i].id == dependentId) {

[Devlin, 2015/03/24 17:52:25]

closure compiler, why you no help me?

[Tyler Breisacher (Chromium), 2015/03/24 18:20:14]

Without looking too deeply, my guess is that this entire function (the anonymous
function from line 741 to 759) was simply not being checked before (though it
will be after this CL). You can enable an "unknown this" check but it's a little
awkward to do since you need a conformance-config text file. Might be worth
doing though. I'll try to find some up-to-date docs on that.

[Tyler Breisacher (Chromium), 2015/03/24 18:22:45]

Er, I guess it's from 735 to 759 but you know what I mean :)

               dependentExtension = this.extensions_[i];
               break;
             }
           }
           if (!dependentExtension)
             return;
 
           var depNode = dependentTemplate.cloneNode(true);
           depNode.querySelector('.dep-extension-title').textContent =
               dependentExtension.name;
           depNode.querySelector('.dep-extension-id').textContent =
               dependentExtension.id;
           dependentList.appendChild(depNode);
         }, this);
-      });
+      }.bind(this));
 
       // The active views.
       this.updateVisibility_(row, '.active-views', extension.views.length > 0,
                              function(item) {
         var link = item.querySelector('a');
 
         // Link needs to be an only child before the list is updated.
         while (link.nextElementSibling)
           item.removeChild(link.nextElementSibling);
 
@@ skipping 204 matching lines @@
       // TODO(dbeam): why do we need to focus <extensionoptions> before and
       // after its showing animation? Makes very little sense to me.
       overlay.setInitialFocus();
     },
   };
 
   return {
     ExtensionList: ExtensionList
   };
 });