[Extensions UI] Fix shared module view in chrome://extensions

[Extensions UI] Fix shared module view in chrome://extensions

BUG=469332
Committed: https://crrev.com/4a892cc1b099fb0e6540f74487d1e738e1dd00e6
Cr-Commit-Position: refs/heads/master@{#322039}

[Devlin, 2015-03-24 17:52:24]

rdevlin.cronin@chromium.org changed reviewers:
+ dbeam@chromium.org

[Devlin, 2015-03-24 17:52:25]

https://codereview.chromium.org/1015013007/diff/1/chrome/browser/resources/ex...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/1015013007/diff/1/chrome/browser/resources/ex...
chrome/browser/resources/extensions/extension_list.js:744: if
(this.extensions_[i].id == dependentId) {
closure compiler, why you no help me?

[Tyler Breisacher (Chromium), 2015-03-24 18:20:13]

tbreisacher@chromium.org changed reviewers:
+ tbreisacher@chromium.org

[Tyler Breisacher (Chromium), 2015-03-24 18:20:14]

https://codereview.chromium.org/1015013007/diff/1/chrome/browser/resources/ex...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/1015013007/diff/1/chrome/browser/resources/ex...
chrome/browser/resources/extensions/extension_list.js:744: if
(this.extensions_[i].id == dependentId) {
On 2015/03/24 17:52:25, Devlin wrote:
> closure compiler, why you no help me?

Without looking too deeply, my guess is that this entire function (the anonymous
function from line 741 to 759) was simply not being checked before (though it
will be after this CL). You can enable an "unknown this" check but it's a little
awkward to do since you need a conformance-config text file. Might be worth
doing though. I'll try to find some up-to-date docs on that.

[Tyler Breisacher (Chromium), 2015-03-24 18:22:45]

lgtm

https://codereview.chromium.org/1015013007/diff/1/chrome/browser/resources/ex...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/1015013007/diff/1/chrome/browser/resources/ex...
chrome/browser/resources/extensions/extension_list.js:744: if
(this.extensions_[i].id == dependentId) {
On 2015/03/24 18:20:14, Tyler Breisacher (Chromium) wrote:
> On 2015/03/24 17:52:25, Devlin wrote:
> > closure compiler, why you no help me?
> 
> Without looking too deeply, my guess is that this entire function (the
anonymous
> function from line 741 to 759) was simply not being checked before (though it
> will be after this CL). You can enable an "unknown this" check but it's a
little
> awkward to do since you need a conformance-config text file. Might be worth
> doing though. I'll try to find some up-to-date docs on that.

Er, I guess it's from 735 to 759 but you know what I mean :)

[Dan Beam, 2015-03-24 18:54:47]

lgtm though it'd be cool to have some tests that just exercise the codepath (if
you get to it someday)

[Devlin, 2015-03-24 18:55:08]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-03-24 18:56:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1015013007/1

[commit-bot: I haz the power, 2015-03-24 19:02:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-24 19:03:45]

Patchset 1 (id:??) landed as
https://crrev.com/4a892cc1b099fb0e6540f74487d1e738e1dd00e6
Cr-Commit-Position: refs/heads/master@{#322039}