Issue 1015013004: Get rid of excess cleverness in benchmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1015013004: Get rid of excess cleverness in benchmark (Closed)

Created:
5 years, 9 months ago by tomhudson

Modified:
5 years, 9 months ago

Reviewers:
djsollen, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Get rid of excess cleverness in benchmark RotatedRectBench was asking for its base layer size, which may not be what it expects with odd canvas modes (particularly proxies). Most benchmarks are not so sophisticated; they hard-wire their size and just use that (expected) value. R=mtklein@google.com,djsollen@google.com BUG=skia:3566 Committed: https://skia.googlesource.com/skia/+/c589f6c9680f76b371b5a0ebcd986f2574751887

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	bench/RotatedRectBench.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015013004/1

5 years, 9 months ago (2015-03-23 14:34:25 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-23 14:46:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c589f6c9680f76b371b5a0ebcd986f2574751887