SupervisedUserSyncService cleanup: Implement SigninManagerBase::Observer

SupervisedUserSyncService cleanup: Implement SigninManagerBase::Observer
instead of listening to prefs::kGoogleServicesLastUsername

Committed: https://crrev.com/034dd924fb78c52e029ffea58633c81731a5eff7
Cr-Commit-Position: refs/heads/master@{#321793}

[Marc Treib, 2015-03-23 14:07:44]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2015-03-23 14:07:44]

Bernhard: PTAL!
Roger: FYI

[Roger Tawa OOO till Jul 10th, 2015-03-23 14:24:45]

rogerta@chromium.org changed reviewers:
+ rogerta@chromium.org

[Roger Tawa OOO till Jul 10th, 2015-03-23 14:24:46]

Looks good Marc.  Two suggestions:

- make the SupervisedUserSyncServiceFactory depend on SigninManagerFactory
- clear on sign out instead of sign in, as Bernhard suggested over email?

[Marc Treib, 2015-03-23 14:40:49]

On 2015/03/23 14:24:46, Roger Tawa wrote:
> Looks good Marc.  Two suggestions:
> 
> - make the SupervisedUserSyncServiceFactory depend on SigninManagerFactory

Good catch, thanks! Done.

> - clear on sign out instead of sign in, as Bernhard suggested over email?

I did it like this to keep as close as possible to the existing behavior. But I
agree clearing on sign-out feels cleaner, and it doesn't seem to break anything.
So, done.

[Bernhard Bauer, 2015-03-23 15:50:02]

lgtm

https://codereview.chromium.org/1015013003/diff/40001/chrome/browser/supervis...
File chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc
(right):

https://codereview.chromium.org/1015013003/diff/40001/chrome/browser/supervis...
chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc:549: //
When the signed in user changes, we clear all data, to avoid supervised
"Clear all data on signout, [...]"?

[Marc Treib, 2015-03-23 16:03:06]

https://codereview.chromium.org/1015013003/diff/40001/chrome/browser/supervis...
File chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc
(right):

https://codereview.chromium.org/1015013003/diff/40001/chrome/browser/supervis...
chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc:549: //
When the signed in user changes, we clear all data, to avoid supervised
On 2015/03/23 15:50:01, Bernhard Bauer wrote:
> "Clear all data on signout, [...]"?

Ah, forgot to update the comment. Done, thanks!

[Marc Treib, 2015-03-23 16:03:18]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2015-03-23 16:03:19]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1015013003/#ps60001
(title: "comment")

[commit-bot: I haz the power, 2015-03-23 16:03:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1015013003/60001

[commit-bot: I haz the power, 2015-03-23 16:56:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-23 16:56:37]

Patchset 4 (id:??) landed as
https://crrev.com/034dd924fb78c52e029ffea58633c81731a5eff7
Cr-Commit-Position: refs/heads/master@{#321793}