src/ports/SkFontHost_win.cpp - Issue 1014953002: Restore GDI text size rounding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontHost_win.cpp

Issue 1014953002: Restore GDI text size rounding. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontHost_win.cpp

diff --git a/src/ports/SkFontHost_win.cpp b/src/ports/SkFontHost_win.cpp

index 67927fd81cc6d8449630ec4047fd498ac941168d..379e7afaaa92d6690790ea196f70a74493618ffb 100755

--- a/src/ports/SkFontHost_win.cpp

+++ b/src/ports/SkFontHost_win.cpp

@@ -633,7 +633,7 @@ SkScalerContext_GDI::SkScalerContext_GDI(SkTypeface* rawTypeface,

fGsA.eM21 = SkScalarToFIXED(-GsA.get(SkMatrix::kMSkewX));

fGsA.eM22 = SkScalarToFIXED(GsA.get(SkMatrix::kMScaleY));

- SkScalar gdiTextSize = scale.fY;

+ SkScalar gdiTextSize = SkScalarRoundToScalar(scale.fY);

reed1 2015/03/18 13:57:08 // Comment here, to document WHY we need the round

bungeman-skia 2015/03/18 14:22:13 Done.

if (gdiTextSize == 0) {

gdiTextSize = SK_Scalar1;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »