media/video/capture/android/imageformat_list.h - Issue 1014943005: Android CaptureAPI Types

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/video/capture/android/imageformat_list.h

Issue 1014943005: Android CaptureAPI Types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added MediaInternalsVideoCaptureDeviceTest.* Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 // This file intentionally does not have header guards, it's included

6 // inside a macro to generate enum and a java class for the values.

7

8 #ifndef DEFINE_ANDROID_IMAGEFORMAT

9 #error "DEFINE_ANDROID_IMAGEFORMAT should be defined."

10 #endif

11

12 // Android graphics ImageFormat mapping, see reference in:

13 // http://developer.android.com/reference/android/graphics/ImageFormat.html

14

15 DEFINE_ANDROID_IMAGEFORMAT(ANDROID_IMAGEFORMAT_NV21, 17)

16 DEFINE_ANDROID_IMAGEFORMAT(ANDROID_IMAGEFORMAT_YV12, 842094169)

17

18 DEFINE_ANDROID_IMAGEFORMAT(ANDROID_IMAGEFORMAT_UNKNOWN, 0)
mcasas 2015/03/19 01:55:13 Update the CL description to indicate why are you Update the CL description to indicate why are you removing this file. Is there any other auto-generated magic that could help us with these enums? (Note that they don't need to coincide with the Java enum values, just need to be the same on both sides of JNI). emircan 2015/03/19 19:52:23 I added an explanation to why it is removed. We c Show quoted text On 2015/03/19 01:55:13, mcasas wrote: > Update the CL description to indicate why are you removing this file. > > Is there any other auto-generated magic that could help us with these > enums? (Note that they don't need to coincide with the Java enum > values, just need to be the same on both sides of JNI). I added an explanation to why it is removed. We could remove the current assigned values on these enums and they will automatically be assigned {0, 1, 2,.., n} and would still work. However, they wouldn't correspond to the values specified on the Android documentation specified in the comments. http://developer.android.com/reference/android/graphics/ImageFormat.html
OLD	NEW

« media/media.gyp ('K') | « media/media.gyp ('k') | media/video/capture/android/video_capture_device_factory_android.cc » ('j') | media/video/capture/video_capture_device.cc » ('J')