Issue 101493002: Remove TreatNullAs=NullString for HTMLTable*Element

Issue 101493002: Remove TreatNullAs=NullString for HTMLTable*Element (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Remove TreatNullAs=NullString for HTMLTable*Element http://whatwg.org/html#HTMLTableCaptionElement-partial http://whatwg.org/html#htmltablecellelement http://whatwg.org/html#HTMLTableCellElement-partial http://whatwg.org/html#htmltableheadercellelement http://whatwg.org/html#HTMLTableDataCellElement-partial http://whatwg.org/html#HTMLTableColElement-partial http://whatwg.org/html#HTMLTableElement-partial http://whatwg.org/html#HTMLTableRowElement-partial http://whatwg.org/html#HTMLTableSectionElement-partial The spec has HTMLTableDataCellElement and HTMLTableHeaderCellElement interfaces which we don't have yet, but ignore that here. HTMLTable*Element.bgColor and HTMLTableElement.cellPadding/cellSpacing have [TreatNullAs=EmptyString] in the spec. HTMLTableCellElement.headers is a DOMSettableTokenList in the spec, so leave it alone until that is fixed. The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: IE throws an exception for the align/vAlign/frame/rules, and reflects border/width/height as the empty string. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163081

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -96 lines)			Patch
M	LayoutTests/fast/dom/element-attribute-js-null.html	View	1 chunk	+29 lines, -29 lines	0 comments	Download
M	LayoutTests/fast/dom/element-attribute-js-null-expected.txt	View	1 chunk	+32 lines, -32 lines	0 comments	Download
M	Source/core/html/HTMLTableCaptionElement.idl	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/html/HTMLTableCellElement.idl	View	1 chunk	+9 lines, -10 lines	0 comments	Download
M	Source/core/html/HTMLTableColElement.idl	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	Source/core/html/HTMLTableElement.idl	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	Source/core/html/HTMLTableRowElement.idl	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	Source/core/html/HTMLTableSectionElement.idl	View	1 chunk	+4 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/101493002/1

7 years ago (2013-12-03 11:56:28 UTC) #3

Message was sent while issue was closed.

Change committed as 163081