Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1014913003: Hide Wallet checkbox when user signs out of sync. (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, estade+watch_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide Wallet checkbox when user signs out of sync. BUG=467775 Committed: https://crrev.com/316283d479f75eb6c6b4ea49394b399ec91d0a7f Cr-Commit-Position: refs/heads/master@{#321482}

Patch Set 1 #

Patch Set 2 : handle null service #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -13 lines) Patch
M chrome/browser/resources/options/autofill_options.js View 3 chunks +17 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.h View 4 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 5 chunks +27 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Evan Stade
5 years, 9 months ago (2015-03-18 00:42:59 UTC) #2
please use gerrit instead
lgtm
5 years, 9 months ago (2015-03-18 21:00:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014913003/1
5 years, 9 months ago (2015-03-18 21:45:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/37615)
5 years, 9 months ago (2015-03-19 00:07:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014913003/1
5 years, 9 months ago (2015-03-19 16:19:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/37927)
5 years, 9 months ago (2015-03-19 17:40:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014913003/20001
5 years, 9 months ago (2015-03-19 23:04:30 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 01:10:55 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 01:11:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/316283d479f75eb6c6b4ea49394b399ec91d0a7f
Cr-Commit-Position: refs/heads/master@{#321482}

Powered by Google App Engine
This is Rietveld 408576698