test/cctest/cctest.h - Issue 1014873002: Make tests pass with weak closure overapproximation enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/cctest.h

Issue 1014873002: Make tests pass with weak closure overapproximation enabled (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/cctest.h

diff --git a/test/cctest/cctest.h b/test/cctest/cctest.h

index e111438cdf7de109e3834dfeba6a41a1fa9a1e9c..08877c8268bc8641a8020b706de25d5f1c4aea53 100644

--- a/test/cctest/cctest.h

+++ b/test/cctest/cctest.h

@@ -558,6 +558,9 @@ static inline void SimulateIncrementalMarking(i::Heap* heap) {

CHECK(marking->IsMarking());

while (!marking->IsComplete()) {

marking->Step(i::MB, i::IncrementalMarking::NO_GC_VIA_STACK_GUARD);

+ if (marking->IsReadyToOverApproximateWeakClosure()) {

+ marking->MarkObjectGroups();

+ }

}

CHECK(marking->IsComplete());

}

« no previous file with comments | « src/heap/incremental-marking.h ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »