src/heap/heap.cc - Issue 1014873002: Make tests pass with weak closure overapproximation enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 1014873002: Make tests pass with weak closure overapproximation enabled (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 6ce23da02908f33323bd8ce6a7b6b1ee4c7e319f..a3548836f3df29671f55333b6a0eefcef34ed528 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -4586,6 +4586,7 @@ bool Heap::TryFinalizeIdleIncrementalMarking(

size_t final_incremental_mark_compact_speed_in_bytes_per_ms) {

if (incremental_marking()->IsReadyToOverApproximateWeakClosure() ||

(FLAG_overapproximate_weak_closure &&

Hannes Payer (out of office) 2015/03/18 09:32:18 The FLAG_overapproximate_weak_closure should guard

+ !incremental_marking()->weak_closure_was_overapproximated() &&

mark_compact_collector_.marking_deque()->IsEmpty() &&

gc_idle_time_handler_.ShouldDoOverApproximateWeakClosure(

static_cast<size_t>(idle_time_in_ms)))) {

« no previous file with comments | « no previous file | src/heap/incremental-marking.h » ('j') | no next file with comments »