Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 1014873002: Make tests pass with weak closure overapproximation enabled (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make tests pass with weak closure overapproximation enabled BUG=v8:3862 R=hpayer@chromium.org LOG=n Committed: https://crrev.com/fe3544b370198827d2eac10a2ec5e9c2149929cb Cr-Commit-Position: refs/heads/master@{#27261}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M src/heap/heap.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M src/heap/incremental-marking.h View 2 chunks +6 lines, -1 line 0 comments Download
M test/cctest/cctest.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-17 16:54:32 UTC) #1
Hannes Payer (out of office)
lgtm, one nit https://codereview.chromium.org/1014873002/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1014873002/diff/1/src/heap/heap.cc#newcode4588 src/heap/heap.cc:4588: (FLAG_overapproximate_weak_closure && The FLAG_overapproximate_weak_closure should guard ...
5 years, 9 months ago (2015-03-18 09:32:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014873002/20001
5 years, 9 months ago (2015-03-18 09:37:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 10:01:28 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 10:01:46 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe3544b370198827d2eac10a2ec5e9c2149929cb
Cr-Commit-Position: refs/heads/master@{#27261}

Powered by Google App Engine
This is Rietveld 408576698