Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1014853005: ozone: evdev: Remove BTN_LEFT from touchscreen probing (Closed)

Created:
5 years, 9 months ago by spang
Modified:
5 years, 9 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Remove BTN_LEFT from touchscreen probing This was intended as a fix for some unusual absolute devices that report having mouse buttons (BTN_LEFT, BTN_MIDDLE, BTN_RIGHT), and aren't touchpads or tablets. They are sort of like touchscreens (user interacts directly with screen), and sort of like tablets (absolute cursor positioning), and sort of like mice (left/middle/right buttons). The fact that it wants mouse events rather than touch events makes it incompatible with the touchscreen code, though, so revert this for now. We'll have to do something else to support these "absolute mouse" devices. BUG=456999 TEST=events_unittests Committed: https://crrev.com/6eb9dbd85840250176d1461aa6354e03492c2a43 Cr-Commit-Position: refs/heads/master@{#321831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/events/ozone/evdev/event_device_info.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
spang
5 years, 9 months ago (2015-03-23 15:24:10 UTC) #2
kpschoedel
lgtm
5 years, 9 months ago (2015-03-23 19:00:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014853005/1
5 years, 9 months ago (2015-03-23 19:02:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014853005/1
5 years, 9 months ago (2015-03-23 19:31:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 19:32:12 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 19:33:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6eb9dbd85840250176d1461aa6354e03492c2a43
Cr-Commit-Position: refs/heads/master@{#321831}

Powered by Google App Engine
This is Rietveld 408576698