Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 1014853002: [turbofan] Clean up TRACE macros and use variadic macros. (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Clean up TRACE macros and use variadic macros. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/c6004a3211a845acdce2a66e38e33fae11f5ac59 Cr-Commit-Position: refs/heads/master@{#27248}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -160 lines) Patch
M src/compiler/control-equivalence.h View 1 2 8 chunks +19 lines, -21 lines 0 comments Download
M src/compiler/control-reducer.cc View 1 14 chunks +26 lines, -25 lines 0 comments Download
M src/compiler/js-inlining.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M src/compiler/jump-threading.cc View 5 chunks +20 lines, -18 lines 0 comments Download
M src/compiler/scheduler.cc View 28 chunks +47 lines, -52 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 8 chunks +32 lines, -31 lines 0 comments Download
M test/unittests/compiler/control-equivalence-unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
titzer
5 years, 9 months ago (2015-03-17 16:39:27 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/1014853002/diff/1/src/compiler/control-equivalence.h File src/compiler/control-equivalence.h (right): https://codereview.chromium.org/1014853002/diff/1/src/compiler/control-equivalence.h#newcode13 src/compiler/control-equivalence.h:13: #define TRACE(...) \ nit: Can we move it ...
5 years, 9 months ago (2015-03-17 17:08:07 UTC) #2
titzer
https://codereview.chromium.org/1014853002/diff/1/src/compiler/control-equivalence.h File src/compiler/control-equivalence.h (right): https://codereview.chromium.org/1014853002/diff/1/src/compiler/control-equivalence.h#newcode13 src/compiler/control-equivalence.h:13: #define TRACE(...) \ On 2015/03/17 17:08:07, Michael Starzinger wrote: ...
5 years, 9 months ago (2015-03-17 17:32:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014853002/20001
5 years, 9 months ago (2015-03-17 17:34:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/3909)
5 years, 9 months ago (2015-03-17 17:47:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014853002/40001
5 years, 9 months ago (2015-03-17 17:55:30 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-17 18:51:13 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 18:51:32 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c6004a3211a845acdce2a66e38e33fae11f5ac59
Cr-Commit-Position: refs/heads/master@{#27248}

Powered by Google App Engine
This is Rietveld 408576698