Revert of Remove dbus_unittests from linux testers.

Revert of https://codereview.chromium.org/107313002/
Reason for revert: breaking the main waterfall

TBR=erg@chromium.org,phajdan.jr@chromium.org,thakis@chromium.org,agable@chromium.org
NOTREECHECKS=true
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=239440

[hashimoto, 2013-12-09 06:35:58]

Created Revert of Remove dbus_unittests from linux testers.

[commit-bot: I haz the power, 2013-12-09 06:36:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/101483004/1

[commit-bot: I haz the power, 2013-12-09 06:37:01]

Change committed as 239440

[Nico, 2013-12-09 15:22:55]

Why not land my cl instead? It fixes this problem, and you need a master
restart in any case.
On Dec 8, 2013 10:37 PM, <commit-bot@chromium.org> wrote:

> Change committed as 239440
>
> https://codereview.chromium.org/101483004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hashimoto, 2013-12-09 16:04:25]

I reverted this CL because I think removing dbus_unittests from Linux
bots is not the right fix for crbug.com/326272.
At least, the discussion is too premature.

On Tue, Dec 10, 2013 at 12:22 AM, Nico Weber <thakis@chromium.org> wrote:
> Why not land my cl instead? It fixes this problem, and you need a master
> restart in any case.
>
> On Dec 8, 2013 10:37 PM, <commit-bot@chromium.org> wrote:
>>
>> Change committed as 239440
>>
>> https://codereview.chromium.org/101483004/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2013-12-09 16:11:20]

On Mon, Dec 9, 2013 at 8:04 AM, Ryo Hashimoto <hashimoto@chromium.org>wrote:

> I reverted this CL because I think removing dbus_unittests from Linux
> bots is not the right fix for crbug.com/326272.
>

Why is this? From what I understand from this bug, dbus_unittests wasn't
supposed to run on Linux.

Do you work on dbus_unittests?


> At least, the discussion is too premature.
>
> On Tue, Dec 10, 2013 at 12:22 AM, Nico Weber <thakis@chromium.org> wrote:
> > Why not land my cl instead? It fixes this problem, and you need a master
> > restart in any case.
> >
> > On Dec 8, 2013 10:37 PM, <commit-bot@chromium.org> wrote:
> >>
> >> Change committed as 239440
> >>
> >> https://codereview.chromium.org/101483004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hashimoto, 2013-12-09 16:25:01]

2013/12/10 1:11 "Nico Weber" <thakis@chromium.org>:
>
> On Mon, Dec 9, 2013 at 8:04 AM, Ryo Hashimoto <hashimoto@chromium.org>
wrote:
>>
>> I reverted this CL because I think removing dbus_unittests from Linux
>> bots is not the right fix for crbug.com/326272.
>
>
> Why is this? From what I understand from this bug, dbus_unittests wasn't
supposed to run on Linux.
>
> Do you work on dbus_unittests?
I've made a number of changes to src/dbus.
I think dbus_unittests (or some of its test cases if not all) should run on
Linux builds because Linux Chrome uses classes under src/dbus. (please see
my comment crbug.com/326272#7)
>
>>
>> At least, the discussion is too premature.
>>
>> On Tue, Dec 10, 2013 at 12:22 AM, Nico Weber <thakis@chromium.org> wrote:
>> > Why not land my cl instead? It fixes this problem, and you need a
master
>> > restart in any case.
>> >
>> > On Dec 8, 2013 10:37 PM, <commit-bot@chromium.org> wrote:
>> >>
>> >> Change committed as 239440
>> >>
>> >> https://codereview.chromium.org/101483004/
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.