Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1014813003: [es6] Object.getPrototypeOf should work with values (Closed)

Created:
5 years, 9 months ago by arv (Not doing code reviews)
Modified:
5 years, 9 months ago
Reviewers:
adamk, rossberg, Yang
CC:
v8-dev, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Object.getPrototypeOf should work with values The final spec for Object.getPrototypeOf calls ToObject on the parameter, which means that it should only throw for null and undefined. For other non object values the prototype of the wrapper should be used. BUG=v8:3964 LOG=N R=adamk, rossberg@chromium.org Committed: https://crrev.com/ea463a916bbe5994b0d2d04e8075058b373b2e2c Cr-Commit-Position: refs/heads/master@{#27354}

Patch Set 1 #

Patch Set 2 : Fix another test #

Patch Set 3 : Update webkit tests and test262 status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -49 lines) Patch
M src/v8natives.js View 1 1 chunk +2 lines, -5 lines 0 comments Download
M test/mjsunit/get-prototype-of.js View 1 chunk +66 lines, -32 lines 0 comments Download
M test/mjsunit/harmony/set-prototype-of.js View 1 1 chunk +2 lines, -8 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M test/webkit/prototypes.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/prototypes-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
arv (Not doing code reviews)
Fix another test
5 years, 9 months ago (2015-03-19 21:14:38 UTC) #1
arv (Not doing code reviews)
PTAL
5 years, 9 months ago (2015-03-19 21:15:59 UTC) #2
adamk
lgtm
5 years, 9 months ago (2015-03-20 08:19:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014813003/20001
5 years, 9 months ago (2015-03-20 14:36:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4064)
5 years, 9 months ago (2015-03-20 14:59:13 UTC) #7
arv (Not doing code reviews)
Update webkit tests and test262 status
5 years, 9 months ago (2015-03-20 16:03:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014813003/40001
5 years, 9 months ago (2015-03-20 16:05:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014813003/40001
5 years, 9 months ago (2015-03-23 08:06:57 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-23 08:40:43 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ea463a916bbe5994b0d2d04e8075058b373b2e2c Cr-Commit-Position: refs/heads/master@{#27354}
5 years, 9 months ago (2015-03-23 08:41:01 UTC) #16
Yang
5 years, 9 months ago (2015-03-24 09:18:45 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1033623002/ by yangguo@chromium.org.

The reason for reverting is: Layout test failures. Please update layout test
expectations before landing this, in order to not block the roll..

Powered by Google App Engine
This is Rietveld 408576698