Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1014813002: [iOS] WeakNSObject assignment is consistent with copy constructor (Closed)

Created:
5 years, 9 months ago by droger
Modified:
5 years, 9 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] WeakNSObject assignment is consistent with copy constructor The copy constructor was changed (in CL https://codereview.chromium.org/853503002/) to allow a WeakNSObject to be copied on a different thread. This CL is making the assignment operator behave consistently with the copy constructor: it is now allowed to assign a WeakNSObject on a different thread. In any case, dereferencing the WeakNSObject on another thread remains disallowed. BUG=394008 Committed: https://crrev.com/1fd547a90acc75c995d8ec901ba52879558a27ae Cr-Commit-Position: refs/heads/master@{#320915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M base/ios/weak_nsobject.h View 1 chunk +3 lines, -1 line 0 comments Download
M base/ios/weak_nsobject_unittest.mm View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
droger
5 years, 9 months ago (2015-03-17 12:50:32 UTC) #2
stuartmorgan
lgtm
5 years, 9 months ago (2015-03-17 14:48:11 UTC) #3
droger
Thanks for the review.
5 years, 9 months ago (2015-03-17 15:09:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014813002/1
5 years, 9 months ago (2015-03-17 15:09:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 15:13:17 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 15:14:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fd547a90acc75c995d8ec901ba52879558a27ae
Cr-Commit-Position: refs/heads/master@{#320915}

Powered by Google App Engine
This is Rietveld 408576698