Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1014753003: Move low battery notification to Message Center. (Closed)

Created:
5 years, 9 months ago by michaelpg
Modified:
5 years, 9 months ago
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, derat+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move low battery notification to Message Center. The low battery notification is a TrayNotificationView. This CL makes it into a message center notification instead, giving it updated icons. This fixes issues caused by using the outdated tray notification style. A new BatteryNotification class is added to show, hide and update the MessageCenter Notification. TrayPower::PowerNotificationView is removed. PowerStatusView and PowerStatusViewTest are simplified. BUG=163120, 371364 R=skuhne@chromium.org, oshima@chromium.org Committed: https://crrev.com/64461c4d9dab2a7f33b2611447d259a94976aca5 Cr-Commit-Position: refs/heads/master@{#321521}

Patch Set 1 : #

Total comments: 20

Patch Set 2 : #

Total comments: 8

Patch Set 3 : Made suggested changes #

Total comments: 3

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -296 lines) Patch
M ash/ash.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
A ash/resources/default_100_percent/cros/notification/notification_battery_critical_icon.png View Binary file 0 comments Download
A ash/resources/default_100_percent/cros/notification/notification_battery_fluctuating_icon.png View Binary file 0 comments Download
A ash/resources/default_100_percent/cros/notification/notification_battery_low_icon.png View Binary file 0 comments Download
A ash/resources/default_200_percent/cros/notification/notification_battery_critical_icon.png View Binary file 0 comments Download
A ash/resources/default_200_percent/cros/notification/notification_battery_fluctuating_icon.png View Binary file 0 comments Download
A ash/resources/default_200_percent/cros/notification/notification_battery_low_icon.png View Binary file 0 comments Download
A ash/system/chromeos/power/battery_notification.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A ash/system/chromeos/power/battery_notification.cc View 1 1 chunk +114 lines, -0 lines 0 comments Download
M ash/system/chromeos/power/power_status_view.h View 3 chunks +4 lines, -19 lines 0 comments Download
M ash/system/chromeos/power/power_status_view.cc View 5 chunks +9 lines, -77 lines 0 comments Download
M ash/system/chromeos/power/power_status_view_unittest.cc View 1 2 3 chunks +10 lines, -106 lines 0 comments Download
M ash/system/chromeos/power/tray_power.h View 3 chunks +4 lines, -5 lines 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 7 chunks +13 lines, -53 lines 0 comments Download
M ash/system/chromeos/power/tray_power_unittest.cc View 1 2 3 5 chunks +79 lines, -26 lines 0 comments Download
M ash/system/chromeos/settings/tray_settings.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/system/system_notifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/system_notifier.cc View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
michaelpg
PTAL.
5 years, 9 months ago (2015-03-17 05:00:36 UTC) #4
Mr4D (OOO till 08-26)
https://codereview.chromium.org/1014753003/diff/40001/ash/system/chromeos/power/battery_notification.cc File ash/system/chromeos/power/battery_notification.cc (right): https://codereview.chromium.org/1014753003/diff/40001/ash/system/chromeos/power/battery_notification.cc#newcode33 ash/system/chromeos/power/battery_notification.cc:33: resource_id = IDR_AURA_NOTIFICATION_BATTERY_FLUCTUATING; ?? What is this? The USB ...
5 years, 9 months ago (2015-03-17 17:04:37 UTC) #5
michaelpg
Some questions. Haven't uploaded changes yet. Thanks! https://codereview.chromium.org/1014753003/diff/40001/ash/system/chromeos/power/battery_notification.cc File ash/system/chromeos/power/battery_notification.cc (right): https://codereview.chromium.org/1014753003/diff/40001/ash/system/chromeos/power/battery_notification.cc#newcode33 ash/system/chromeos/power/battery_notification.cc:33: resource_id = ...
5 years, 9 months ago (2015-03-17 18:32:46 UTC) #6
Mr4D (OOO till 08-26)
See comments! https://codereview.chromium.org/1014753003/diff/40001/ash/system/chromeos/power/battery_notification.cc File ash/system/chromeos/power/battery_notification.cc (right): https://codereview.chromium.org/1014753003/diff/40001/ash/system/chromeos/power/battery_notification.cc#newcode58 ash/system/chromeos/power/battery_notification.cc:58: if (status.IsUsbChargerConnected()) { Okay. Somehow this is ...
5 years, 9 months ago (2015-03-17 22:25:05 UTC) #7
michaelpg
https://codereview.chromium.org/1014753003/diff/40001/ash/system/chromeos/power/battery_notification.cc File ash/system/chromeos/power/battery_notification.cc (right): https://codereview.chromium.org/1014753003/diff/40001/ash/system/chromeos/power/battery_notification.cc#newcode58 ash/system/chromeos/power/battery_notification.cc:58: if (status.IsUsbChargerConnected()) { On 2015/03/17 22:25:04, Mr4D wrote: > ...
5 years, 9 months ago (2015-03-17 23:10:39 UTC) #10
oshima
https://codereview.chromium.org/1014753003/diff/100001/ash/system/chromeos/power/power_status_view.h File ash/system/chromeos/power/power_status_view.h (right): https://codereview.chromium.org/1014753003/diff/100001/ash/system/chromeos/power/power_status_view.h#newcode22 ash/system/chromeos/power/power_status_view.h:22: PowerStatusView(bool default_view_right_align); explicit https://codereview.chromium.org/1014753003/diff/100001/ash/system/chromeos/power/power_status_view_unittest.cc File ash/system/chromeos/power/power_status_view_unittest.cc (right): https://codereview.chromium.org/1014753003/diff/100001/ash/system/chromeos/power/power_status_view_unittest.cc#newcode47 ash/system/chromeos/power/power_status_view_unittest.cc:47: ...
5 years, 9 months ago (2015-03-19 21:06:44 UTC) #11
michaelpg
https://codereview.chromium.org/1014753003/diff/100001/ash/system/chromeos/power/tray_power_unittest.cc File ash/system/chromeos/power/tray_power_unittest.cc (right): https://codereview.chromium.org/1014753003/diff/100001/ash/system/chromeos/power/tray_power_unittest.cc#newcode165 ash/system/chromeos/power/tray_power_unittest.cc:165: SCOPED_TRACE(""); On 2015/03/19 21:06:43, oshima wrote: > do you ...
5 years, 9 months ago (2015-03-19 21:38:50 UTC) #12
oshima
https://codereview.chromium.org/1014753003/diff/100001/ash/system/chromeos/power/tray_power_unittest.cc File ash/system/chromeos/power/tray_power_unittest.cc (right): https://codereview.chromium.org/1014753003/diff/100001/ash/system/chromeos/power/tray_power_unittest.cc#newcode165 ash/system/chromeos/power/tray_power_unittest.cc:165: SCOPED_TRACE(""); On 2015/03/19 21:38:50, michaelpg wrote: > On 2015/03/19 ...
5 years, 9 months ago (2015-03-19 21:42:00 UTC) #13
michaelpg
PTAL, thanks! https://codereview.chromium.org/1014753003/diff/100001/ash/system/chromeos/power/power_status_view.h File ash/system/chromeos/power/power_status_view.h (right): https://codereview.chromium.org/1014753003/diff/100001/ash/system/chromeos/power/power_status_view.h#newcode22 ash/system/chromeos/power/power_status_view.h:22: PowerStatusView(bool default_view_right_align); On 2015/03/19 21:06:43, oshima wrote: ...
5 years, 9 months ago (2015-03-20 00:16:34 UTC) #14
oshima
lgtm with a nit. https://codereview.chromium.org/1014753003/diff/120001/ash/system/chromeos/power/tray_power_unittest.cc File ash/system/chromeos/power/tray_power_unittest.cc (right): https://codereview.chromium.org/1014753003/diff/120001/ash/system/chromeos/power/tray_power_unittest.cc#newcode165 ash/system/chromeos/power/tray_power_unittest.cc:165: SCOPED_TRACE("Expected no notifications when no ...
5 years, 9 months ago (2015-03-20 00:53:16 UTC) #15
michaelpg
Thanks, just a quick question. https://codereview.chromium.org/1014753003/diff/120001/ash/system/chromeos/power/tray_power_unittest.cc File ash/system/chromeos/power/tray_power_unittest.cc (right): https://codereview.chromium.org/1014753003/diff/120001/ash/system/chromeos/power/tray_power_unittest.cc#newcode165 ash/system/chromeos/power/tray_power_unittest.cc:165: SCOPED_TRACE("Expected no notifications when ...
5 years, 9 months ago (2015-03-20 00:55:47 UTC) #16
Mr4D (OOO till 08-26)
lgtm https://codereview.chromium.org/1014753003/diff/40001/ash/system/chromeos/power/tray_power.h File ash/system/chromeos/power/tray_power.h (right): https://codereview.chromium.org/1014753003/diff/40001/ash/system/chromeos/power/tray_power.h#newcode93 ash/system/chromeos/power/tray_power.h:93: scoped_ptr<BatteryNotification> battery_notification_; Okay. Now with your changes it ...
5 years, 9 months ago (2015-03-20 03:10:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014753003/160001
5 years, 9 months ago (2015-03-20 03:57:08 UTC) #21
michaelpg
Thanks! Glad to get this in for 43. https://codereview.chromium.org/1014753003/diff/120001/ash/system/chromeos/power/tray_power_unittest.cc File ash/system/chromeos/power/tray_power_unittest.cc (right): https://codereview.chromium.org/1014753003/diff/120001/ash/system/chromeos/power/tray_power_unittest.cc#newcode165 ash/system/chromeos/power/tray_power_unittest.cc:165: SCOPED_TRACE("Expected ...
5 years, 9 months ago (2015-03-20 03:57:12 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:160001)
5 years, 9 months ago (2015-03-20 05:41:32 UTC) #23
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 05:42:20 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/64461c4d9dab2a7f33b2611447d259a94976aca5
Cr-Commit-Position: refs/heads/master@{#321521}

Powered by Google App Engine
This is Rietveld 408576698