Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Issue 1014723007: Remove deprecated PPB_Messaging_1_1 (Closed)

Created:
5 years, 9 months ago by dmichael (off chromium)
Modified:
5 years, 9 months ago
Reviewers:
bbudge
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, jam, raymes+watch_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, bradnelson+warch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, Sam Clegg, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated PPB_Messaging_1_1 This API was never officially supported, but I left in ABI compatibility for a while for the Google Earth prototype. They're now on the stable 1.2 version, so this version of the API can go away. sky TBRed for trivial change to chrome/common/ppapi_utils binji TBRed for native_client_sdk BUG=414398 TBR=sky@chromium.org,binji@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/55d1fac1124e1a803eac50ee1a42b3f2b2d560ba Cr-Commit-Position: refs/heads/master@{#322405}

Patch Set 1 #

Patch Set 2 : Remove from interfaces_ppb_public_dev_channel.h and histograms.xml #

Total comments: 3

Patch Set 3 : revert change to histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -269 lines) Patch
M chrome/common/ppapi_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/api/ppb_messaging.idl View 1 chunk +2 lines, -0 lines 0 comments Download
D ppapi/c/dev/ppb_messaging_deprecated.h View 1 chunk +0 lines, -47 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/message_handler.h View 3 chunks +0 lines, -17 lines 0 comments Download
M ppapi/proxy/message_handler.cc View 6 chunks +0 lines, -112 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev_channel.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ppapi/thunk/ppb_messaging_thunk.cc View 4 chunks +10 lines, -43 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
dmichael (off chromium)
5 years, 9 months ago (2015-03-24 23:00:28 UTC) #2
bbudge
On 2015/03/24 23:00:28, dmichael wrote: Looks like another patchset will be needed. I'll hold off ...
5 years, 9 months ago (2015-03-24 23:17:07 UTC) #3
dmichael (off chromium)
"I always do that. I always mess up some mundane detail." Building locally; I think ...
5 years, 9 months ago (2015-03-25 16:21:33 UTC) #4
bbudge
Question about histograms.xml, otherwise, LGTM https://codereview.chromium.org/1014723007/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1014723007/diff/20001/tools/metrics/histograms/histograms.xml#oldcode56571 tools/metrics/histograms/histograms.xml:56571: - <int value="2001322203" label="PPB_Messaging;1.1"/> ...
5 years, 9 months ago (2015-03-25 17:26:39 UTC) #5
dmichael (off chromium)
+asvitkine for histograms.xml https://codereview.chromium.org/1014723007/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1014723007/diff/20001/tools/metrics/histograms/histograms.xml#oldcode56571 tools/metrics/histograms/histograms.xml:56571: - <int value="2001322203" label="PPB_Messaging;1.1"/> On 2015/03/25 ...
5 years, 9 months ago (2015-03-25 17:38:50 UTC) #7
dmichael (off chromium)
-asvitkine (away), +isherman for histograms.xml
5 years, 9 months ago (2015-03-25 17:41:43 UTC) #9
Ilya Sherman
histograms.xml, though please see the comment inline https://codereview.chromium.org/1014723007/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1014723007/diff/20001/tools/metrics/histograms/histograms.xml#oldcode56571 tools/metrics/histograms/histograms.xml:56571: - <int ...
5 years, 9 months ago (2015-03-25 20:42:26 UTC) #10
dmichael (off chromium)
On 2015/03/25 20:42:26, Ilya Sherman wrote: > histograms.xml, though please see the comment inline > ...
5 years, 9 months ago (2015-03-25 21:39:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014723007/40001
5 years, 9 months ago (2015-03-25 21:40:42 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51920)
5 years, 9 months ago (2015-03-25 21:53:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014723007/40001
5 years, 9 months ago (2015-03-26 16:13:14 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-26 17:07:05 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 17:08:31 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/55d1fac1124e1a803eac50ee1a42b3f2b2d560ba
Cr-Commit-Position: refs/heads/master@{#322405}

Powered by Google App Engine
This is Rietveld 408576698