content/browser/storage_partition_impl.cc - Issue 1014703007: The platform notification context should observe the Service Worker Context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/storage_partition_impl.cc

Issue 1014703007: The platform notification context should observe the Service Worker Context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-db-ReadAllData

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/platform_notification_context_unittest.cc ('k') | content/public/browser/platform_notification_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/storage_partition_impl.cc

diff --git a/content/browser/storage_partition_impl.cc b/content/browser/storage_partition_impl.cc

index 4ec2db715252edfee3d7abc2bd9e4989b36783bb..f98cb25c522f91d0ae58f293a2c3ed82909f96e0 100644

--- a/content/browser/storage_partition_impl.cc

+++ b/content/browser/storage_partition_impl.cc

@@ -422,6 +422,9 @@ StoragePartitionImpl::~StoragePartitionImpl() {

if (GetGeofencingManager())

GetGeofencingManager()->Shutdown();

+ if (GetPlatformNotificationContext())

+ GetPlatformNotificationContext()->Shutdown();

}

StoragePartitionImpl* StoragePartitionImpl::Create(

@@ -510,7 +513,8 @@ StoragePartitionImpl* StoragePartitionImpl::Create(

new NavigatorConnectServiceWorkerServiceFactory(service_worker_context)));

scoped_refptr<PlatformNotificationContextImpl> platform_notification_context =

- new PlatformNotificationContextImpl(path);

+ new PlatformNotificationContextImpl(path, service_worker_context);

+ platform_notification_context->Initialize();

StoragePartitionImpl* storage_partition = new StoragePartitionImpl(

context, partition_path, quota_manager.get(), appcache_service.get(),