content/public/renderer/render_frame_observer.h - Issue 1014703003: Allow IPCs during RenderFrameObserver::FrameDetached()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/render_frame_observer.h

Issue 1014703003: Allow IPCs during RenderFrameObserver::FrameDetached() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/renderer/render_frame_observer.h

diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h

index 79957c4f96c4a0946e7c91f17d2450618e0b2252..161f6c8c3bc9ea12cb99f70c42988feb575182fe 100644

--- a/content/public/renderer/render_frame_observer.h

+++ b/content/public/renderer/render_frame_observer.h

@@ -63,8 +63,8 @@ class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,

// Called before FrameWillClose, when this frame has been detached from the

// view, but has not been closed yet. This *will* be called when parent frames

- // are closing. NB: IPCs to the browser will fail silently by the time this

- // notification is sent.

+ // are closing. Since the frame is already detached from the DOM at this time

+ // it should not be inspected.

virtual void FrameDetached() {}

// Called when the frame will soon be closed. This is the last opportunity to

« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »