components/password_manager/core/browser/password_manager.cc - Issue 1014683006: [Password manager] Recognise squashed login+sign-up forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1014683006: [Password manager] Recognise squashed login+sign-up forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing PasswordManagerTest Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_form_manager.cc ('K') | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | components/password_manager/core/browser/password_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index 3d6111c7e6ef1c33c0a48a895906ca0b255cfabe..38f2df9b836421b535ad10682ad32cded7f998d6 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -219,8 +219,7 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {

}

// No password to save? Then don't.

- if ((form.new_password_element.empty() && form.password_value.empty()) ||

- (!form.new_password_element.empty() && form.new_password_value.empty())) {

+ if (PasswordFormManager::PasswordToSave(form).empty()) {

RecordFailure(EMPTY_PASSWORD, form.origin, logger.get());

return;

}