Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5103)

Unified Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 1014683006: [Password manager] Recognise squashed login+sign-up forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: LazyInstance + commented regexp Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 65ecd63a643a05949e276ff033cd30f416c7b2dd..b04c72f336097767e5ffdb1e3525fe8a3f110e18 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -1801,3 +1801,47 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
EXPECT_TRUE(prompt_observer->IsShowingPrompt());
}
+
+// Tests that if a site embeds the login and signup forms into one <form>, the
+// login form still gets autofilled.
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
+ AutofillSuggetionsForLoginSignupForm) {
+ password_manager::TestPasswordStore* password_store =
+ static_cast<password_manager::TestPasswordStore*>(
+ PasswordStoreFactory::GetForProfile(
+ browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS).get());
+
+ EXPECT_TRUE(password_store->IsEmpty());
+
+ NavigateToFile("/password/login_signup_form.html");
+
+ NavigationObserver observer(WebContents());
+ scoped_ptr<PromptObserver> prompt_observer(
+ PromptObserver::Create(WebContents()));
+ std::string submit =
+ "document.getElementById('username').value = 'myusername';"
+ "document.getElementById('password').value = 'mypassword';"
+ "document.getElementById('submit').click();";
+ ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), submit));
+ observer.Wait();
+
+ prompt_observer->Accept();
+
+ // Spin the message loop to make sure the password store had a chance to save
+ // the password.
+ base::RunLoop run_loop;
+ run_loop.RunUntilIdle();
+ EXPECT_FALSE(password_store->IsEmpty());
+
+ // Now, navigate to the same html password form and verify whether password is
+ // autofilled.
+ NavigateToFile("/password/login_signup_form.html");
+
+ // Let the user interact with the page, so that DOM gets modification events,
+ // needed for autofilling fields.
+ content::SimulateMouseClickAt(
+ WebContents(), 0, blink::WebMouseEvent::ButtonLeft, gfx::Point(1, 1));
+
+ // Wait until that interaction causes the password value to be revealed.
+ WaitForElementValue("password", "mypassword");
+}

Powered by Google App Engine
This is Rietveld 408576698