Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1014663002: Buildfix for Ozone Linux build: guard build/linux/system.gyp:atk dep. (Closed)

Created:
5 years, 9 months ago by gunsch
Modified:
5 years, 9 months ago
Reviewers:
dmazzoni, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Buildfix for Ozone Linux build: guard build/linux/system.gyp:atk dep. R=dmazzoni@chromium.org BUG=None Committed: https://crrev.com/1f11e922c34e28786c16436839ca9146df10fd74 Cr-Commit-Position: refs/heads/master@{#320829}

Patch Set 1 #

Total comments: 2

Patch Set 2 : separate out atk dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/views/views.gyp View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
gunsch
5 years, 9 months ago (2015-03-16 21:28:40 UTC) #1
dmazzoni
https://codereview.chromium.org/1014663002/diff/1/ui/views/views.gyp File ui/views/views.gyp (right): https://codereview.chromium.org/1014663002/diff/1/ui/views/views.gyp#newcode638 ui/views/views.gyp:638: ['OS=="linux" and chromeos==0 and use_ozone==0', { My change only ...
5 years, 9 months ago (2015-03-16 21:36:00 UTC) #2
gunsch
https://codereview.chromium.org/1014663002/diff/1/ui/views/views.gyp File ui/views/views.gyp (right): https://codereview.chromium.org/1014663002/diff/1/ui/views/views.gyp#newcode638 ui/views/views.gyp:638: ['OS=="linux" and chromeos==0 and use_ozone==0', { On 2015/03/16 21:36:00, ...
5 years, 9 months ago (2015-03-16 21:39:04 UTC) #4
dmazzoni
lgtm
5 years, 9 months ago (2015-03-16 21:43:38 UTC) #5
sky
LGTM
5 years, 9 months ago (2015-03-16 23:09:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014663002/20001
5 years, 9 months ago (2015-03-16 23:10:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 00:22:32 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 00:23:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f11e922c34e28786c16436839ca9146df10fd74
Cr-Commit-Position: refs/heads/master@{#320829}

Powered by Google App Engine
This is Rietveld 408576698