Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 101463008: [NOT FOR REVIEW][PPAPI] Implement MediaStreamVideoTrack pepper API (Closed)

Created:
6 years, 11 months ago by Peng
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Greg Billock, kmixter1, Ronghua Wu (Left Chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

Implement MediaStreamVideoTrack pepper API MediaStreamTrack Classes Hierarchy https://docs.google.com/a/google.com/document/d/19bkcUW8WGvXhNHEaDYxnq8JH9LCWsB4a8kxJyPEJzTc/edit#heading=h.ytqwc0tznx3k BUG=330851

Patch Set 1 : Update #

Total comments: 1

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1519 lines, -202 lines) Patch
M chrome/browser/component_updater/ppapi_utils.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
A content/renderer/pepper/pepper_media_stream_track_host_base.h View 1 1 chunk +57 lines, -0 lines 0 comments Download
A content/renderer/pepper/pepper_media_stream_track_host_base.cc View 1 1 chunk +100 lines, -0 lines 0 comments Download
A content/renderer/pepper/pepper_media_stream_video_track_host.h View 1 chunk +58 lines, -0 lines 0 comments Download
A content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 1 chunk +122 lines, -0 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/pepper/resource_converter.cc View 6 chunks +53 lines, -5 lines 0 comments Download
M ppapi/api/ppb_media_stream_video_track.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/c/ppb_media_stream_video_track.h View 2 chunks +1 line, -4 lines 0 comments Download
M ppapi/cpp/media_stream_video_track.h View 1 chunk +0 lines, -4 lines 0 comments Download
A + ppapi/examples/media_stream_video/media_stream_video.cc View 14 chunks +63 lines, -182 lines 0 comments Download
A ppapi/examples/media_stream_video/media_stream_video.html View 1 chunk +48 lines, -0 lines 0 comments Download
M ppapi/host/ppapi_host.h View 3 chunks +8 lines, -0 lines 0 comments Download
M ppapi/host/ppapi_host.cc View 2 chunks +16 lines, -1 line 0 comments Download
M ppapi/ppapi_proxy.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 3 chunks +8 lines, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +10 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A ppapi/proxy/media_stream_track_resource_base.h View 1 1 chunk +69 lines, -0 lines 0 comments Download
A ppapi/proxy/media_stream_track_resource_base.cc View 1 1 chunk +85 lines, -0 lines 0 comments Download
A ppapi/proxy/media_stream_video_track_resource.h View 1 chunk +56 lines, -0 lines 0 comments Download
A ppapi/proxy/media_stream_video_track_resource.cc View 1 1 chunk +100 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_var_tracker.cc View 3 chunks +19 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 2 chunks +13 lines, -1 line 0 comments Download
A ppapi/proxy/video_frame_resource.h View 1 chunk +63 lines, -0 lines 0 comments Download
A ppapi/proxy/video_frame_resource.cc View 1 chunk +79 lines, -0 lines 0 comments Download
A ppapi/shared_impl/media_stream_frame.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ppapi/shared_impl/media_stream_frame_buffer.h View 1 1 chunk +77 lines, -0 lines 0 comments Download
A ppapi/shared_impl/media_stream_frame_buffer.cc View 1 1 chunk +78 lines, -0 lines 0 comments Download
M ppapi/shared_impl/resource.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_media_stream_track_api.h View 1 chunk +33 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_media_stream_video_track_api.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_media_stream_video_track_thunk.cc View 1 chunk +96 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_video_frame_api.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_video_frame_thunk.cc View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peng
Hi, During reviewing of CL 119853003, I found a circular buffer is not a good ...
6 years, 11 months ago (2014-01-07 20:08:14 UTC) #1
yzshen1
Hi, Peng: A few high level comments: - Please consider splitting the code into multiple ...
6 years, 11 months ago (2014-01-07 23:57:35 UTC) #2
Peng
6 years, 11 months ago (2014-01-08 15:07:11 UTC) #3
On 2014/01/07 23:57:35, yzshen1 wrote:
> Hi, Peng:
> 
> A few high level comments:
> - Please consider splitting the code into multiple CLs, for example:
>   * the API boilerplates: *_api, *_thunk and many other files except the real
> implementation
>   * the real implementation: *_host, *_resource
>   * the example.
> 
>   That is actually a faster way to get your code landed. It reduces the work
of
> resolving conflicts. It avoids the risk of all code being reverted if any
issues
> show up on the waterfall. Besides, some less critial code such as example
won't
> block the other part. And it is easiers for reviewers to do load balancing.
> 
>   (I am not saying that it is a must. If you still feel like to go ahead with
a
> single big CL, that is fine. But please think about it. :))
> 
> - Maybe we don't need to make MediaStreamTrackBaseShared a base class. You
could
> call it MediaStreamFrameBuffer and make it a member of Track classes.
> 
> What do you think?

That is really good idea. I will split this CL to several small CLs. Thanks

> 
>
https://codereview.chromium.org/101463008/diff/120002/ppapi/thunk/interfaces_...
> File ppapi/thunk/interfaces_ppb_public_stable.h (right):
> 
>
https://codereview.chromium.org/101463008/diff/120002/ppapi/thunk/interfaces_...
> ppapi/thunk/interfaces_ppb_public_stable.h:70:
> PROXIED_IFACE(PPB_MEDIASTREAMVIDEOTRACK_INTERFACE_0_1,
> Please put them in interfaces_ppb_public_dev_channel.h

Powered by Google App Engine
This is Rietveld 408576698