Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 101463006: Move <outputs> element in Android .grd files. (Closed)

Created:
6 years, 11 months ago by newt (away)
Modified:
6 years, 11 months ago
Reviewers:
Ted C, Nico
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move <outputs> element in Android .grd files. This moves up the <outputs> and <translations> elements to the top of the grd file to be consistent with other grd files. R=tedchoc@chromium.org, thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -273 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 2 chunks +91 lines, -91 lines 0 comments Download
M content/public/android/java/strings/android_content_strings.grd View 2 chunks +91 lines, -91 lines 0 comments Download
M ui/android/java/strings/android_ui_strings.grd View 2 chunks +91 lines, -91 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
newt (away)
PTAL
6 years, 11 months ago (2014-01-06 22:48:52 UTC) #1
Nico
stampy lgtm
6 years, 11 months ago (2014-01-06 22:55:12 UTC) #2
newt (away)
+tedchoc: for android_content_strings.grd
6 years, 11 months ago (2014-01-07 16:09:37 UTC) #3
Ted C
On 2014/01/07 16:09:37, newt wrote: > +tedchoc: for android_content_strings.grd lgtm
6 years, 11 months ago (2014-01-07 17:30:16 UTC) #4
newt (away)
6 years, 11 months ago (2014-01-07 17:36:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r243320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698