Issue 101463005: Inline devtools_discovery_page_resources.grd into browser_resources.grd.

Issue 101463005: Inline devtools_discovery_page_resources.grd into browser_resources.grd. (Closed)

Created:
6 years, 11 months ago by Nico

Modified:
6 years, 10 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Inline devtools_discovery_page_resources.grd into browser_resources.grd. BUG=297672 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251920

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -34 lines)			Patch
M	chrome/browser/android/dev_tools_server.cc	View	1 chunk	+1 line, -1 line	1 comment	Download
M	chrome/browser/browser_resources.grd	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/devtools/browser_list_tabcontents_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/devtools/frontend/devtools_discovery_page_resources.grd	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	chrome/chrome_resources.gyp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	tools/gn/secondary/chrome/BUILD.gn	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	tools/gritsettings/resource_ids	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/101463005/diff/1/chrome/browser/android/dev_tools_server.cc File chrome/browser/android/dev_tools_server.cc (right): https://codereview.chromium.org/101463005/diff/1/chrome/browser/android/dev_tools_server.cc#newcode40 chrome/browser/android/dev_tools_server.cc:40: #include "grit/browser_resources.h" I am not sure it is ok ...

6 years, 11 months ago (2014-01-07 15:17:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/101463005/1

6 years, 10 months ago (2014-02-18 22:36:21 UTC) #6

Message was sent while issue was closed.

Change committed as 251920

Expand Messages | Collapse Messages