Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 101463003: Revert "Introduce API to temporarily interrupt long running JavaScript code." (Closed)

Created:
7 years ago by Vyacheslav Egorov (Chromium)
Modified:
7 years ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert "Introduce API to temporarily interrupt long running JavaScript code." This reverts commit r18363. Revert "Fix compilation error introduced by r18363." This reverts commit r18364. Changes in SCE pass are incompatible with parallel compilation TBR=dcarney@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -359 lines) Patch
M include/v8.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/execution.h View 3 chunks +1 line, -10 lines 0 comments Download
M src/execution.cc View 4 chunks +0 lines, -49 lines 0 comments Download
M src/hydrogen-instructions.h View 5 chunks +3 lines, -17 lines 0 comments Download
M src/hydrogen-sce.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 2 chunks +1 line, -252 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vyacheslav Egorov (Chromium)
7 years ago (2013-12-18 19:20:38 UTC) #1
Vyacheslav Egorov (Chromium)
Committed patchset #1 manually as r18365.
7 years ago (2013-12-18 19:21:38 UTC) #2
Yang
On 2013/12/18 19:21:38, Vyacheslav Egorov wrote: > Committed patchset #1 manually as r18365. The issue ...
7 years ago (2013-12-19 09:10:36 UTC) #3
dcarney
7 years ago (2013-12-19 09:19:17 UTC) #4
Message was sent while issue was closed.
On 2013/12/19 09:10:36, Yang wrote:
> On 2013/12/18 19:21:38, Vyacheslav Egorov wrote:
> > Committed patchset #1 manually as r18365.
> 
> The issue with HasStackCheck is that it accesses the heap during the
> optimization phase, which could happen on the concurrent thread. The simple
> solution is to simply compute its result upfront during graph building (in the
> constructor of the HInstruction).

yeah this was fixed in https://codereview.chromium.org/104823008/

Powered by Google App Engine
This is Rietveld 408576698