Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1014623003: [Ozone] Fix Vaapi unittest builds (Closed)

Created:
5 years, 9 months ago by dnicoara
Modified:
5 years, 9 months ago
Reviewers:
spang
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone] Fix Vaapi unittest builds BUG=none Committed: https://crrev.com/638dcf8ea48510475248361caeca547c4541b950 Cr-Commit-Position: refs/heads/master@{#320758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
dnicoara
5 years, 9 months ago (2015-03-16 17:37:20 UTC) #2
spang
lgtm
5 years, 9 months ago (2015-03-16 17:38:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014623003/1
5 years, 9 months ago (2015-03-16 18:23:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 18:35:30 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/638dcf8ea48510475248361caeca547c4541b950 Cr-Commit-Position: refs/heads/master@{#320758}
5 years, 9 months ago (2015-03-16 18:39:47 UTC) #7
spang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1012213002/ by spang@chromium.org. ...
5 years, 9 months ago (2015-03-17 20:22:39 UTC) #8
Adrian Kuegel
On 2015/03/17 20:22:39, spang wrote: > A revert of this CL (patchset #1 id:1) has ...
5 years, 9 months ago (2015-03-18 08:57:41 UTC) #9
dnicoara
5 years, 9 months ago (2015-03-18 12:33:29 UTC) #10
Message was sent while issue was closed.
On 2015/03/18 08:57:41, Adrian Kuegel wrote:
> On 2015/03/17 20:22:39, spang wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/1012213002/ by mailto:spang@chromium.org.
> > 
> > The reason for reverting is: Breaks CrOS !ozone build..
> 
> So what is the proper way to fix the broken ozone build? This is currently
> affecting the Codesearch bots, because I enabled ozone there.

Fix is at https://codereview.chromium.org/1017843002/

Powered by Google App Engine
This is Rietveld 408576698