Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1014573003: Adding Travis CI and Coveralls support (Closed)

Created:
5 years, 9 months ago by kevmoo
Modified:
5 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart-dev-compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adding Travis CI and Coveralls support only use compact config if we're not doing code coverage R=sigmund@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/208251874f9caffc8e4be912572f0727e7329e5d

Patch Set 1 #

Total comments: 8

Patch Set 2 : rebase, readme #

Patch Set 3 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -22 lines) Patch
A .travis.yml View 1 chunk +7 lines, -0 lines 0 comments Download
M README.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/all_tests.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M test/checker/checker_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M test/checker/inferred_type_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M test/checker/self_host_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M test/dependency_graph_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M test/report_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
A test/test_util.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A tool/travis.sh View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
kevmoo
5 years, 9 months ago (2015-03-17 01:46:56 UTC) #2
Siggi Cherem (dart-lang)
This is really nice! Some small comments below, but otherwise LGTM. https://codereview.chromium.org/1014573003/diff/1/pubspec.yaml File pubspec.yaml (right): ...
5 years, 9 months ago (2015-03-17 15:03:50 UTC) #3
kevmoo
https://codereview.chromium.org/1014573003/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1014573003/diff/1/pubspec.yaml#newcode6 pubspec.yaml:6: url: https://github.com/dart-lang/ddc_analyzer.git On 2015/03/17 15:03:50, Siggi Cherem (dart-lang) wrote: ...
5 years, 9 months ago (2015-03-17 15:14:39 UTC) #4
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1014573003/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1014573003/diff/1/pubspec.yaml#newcode6 pubspec.yaml:6: url: https://github.com/dart-lang/ddc_analyzer.git On 2015/03/17 15:14:38, kevmoo wrote: > ...
5 years, 9 months ago (2015-03-17 15:18:07 UTC) #5
kevmoo
Committed patchset #3 (id:40001) manually as 208251874f9caffc8e4be912572f0727e7329e5d (presubmit successful).
5 years, 9 months ago (2015-03-17 15:20:00 UTC) #6
Jennifer Messerly
5 years, 9 months ago (2015-03-17 15:30:12 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1014573003/diff/1/tool/travis.sh
File tool/travis.sh (right):

https://codereview.chromium.org/1014573003/diff/1/tool/travis.sh#newcode16
tool/travis.sh:16: dart --checked test/all_tests.dart
On 2015/03/17 15:14:38, kevmoo wrote:
> On 2015/03/17 15:03:50, Siggi Cherem (dart-lang) wrote:
> > could we call `source test/test.sh` here instead? it runs "all_tests.dart"
but
> > also validates the output of the compiler, runs the analyzer, and checks
that
> > all files are formatted correctly.
> 
> Yes, but let me get this in first.
> 
> I was having trouble getting tesh.sh to pass on travis. Wanted to get
something
> in first.

if it helps, we can move the diff'ing of expected output into the Dart test
code.
but test.sh is still nice because it runs the analyzer :)

Powered by Google App Engine
This is Rietveld 408576698