Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2092)

Unified Diff: content/renderer/renderer_blink_platform_impl.h

Issue 1014543003: Add an IPC method for Blink to call RapporService::RecordSample() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix all review comments, ran "git cl format" Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/renderer_blink_platform_impl.h
diff --git a/content/renderer/renderer_blink_platform_impl.h b/content/renderer/renderer_blink_platform_impl.h
index 7691aca0e405c7ae1bd2f195ba0c6ee19b4e0b9a..f91e8cf47f91d88a1ca8fef3090bd65271245f86 100644
--- a/content/renderer/renderer_blink_platform_impl.h
+++ b/content/renderer/renderer_blink_platform_impl.h
@@ -159,6 +159,8 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl {
virtual void cancelVibration();
virtual blink::WebScheduler* scheduler();
virtual blink::WebThread* currentThread();
+ virtual void recordRappor(const char* metric, const blink::WebString& sample);
Alexei Svitkine (slow) 2015/04/08 14:57:11 Maybe add the same comment about Rappor here that
kojii 2015/04/08 17:31:46 Hm, these two are virtual override of platform.h i
Alexei Svitkine (slow) 2015/04/08 17:53:50 Fair enough.
+ virtual void recordRapporURL(const char* metric, const blink::WebURL& url);
// Set the PlatformEventObserverBase in |platform_event_observers_| associated
// with |type| to |observer|. If there was already an observer associated to

Powered by Google App Engine
This is Rietveld 408576698