Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 1014503005: Remove suppression of GpuRasterization.BlueBox on Mac (Closed)

Created:
5 years, 9 months ago by ccameron
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Corentin Wallez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove suppression of GpuRasterization.BlueBox on Mac The regressing CLs have been reverted. BUG=466690 Committed: https://crrev.com/772e590605971ee9c165e4ffdfec844edaf017f8 Cr-Commit-Position: refs/heads/master@{#320789}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add passs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/test/gpu/gpu_tests/gpu_rasterization_expectations.py View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ccameron
The latest skia roll picked up the needed patches.
5 years, 9 months ago (2015-03-16 18:37:32 UTC) #2
Ken Russell (switch to Gerrit)
Thanks for getting to the bottom of this. https://codereview.chromium.org/1014503005/diff/1/content/test/gpu/gpu_tests/gpu_rasterization_expectations.py File content/test/gpu/gpu_tests/gpu_rasterization_expectations.py (right): https://codereview.chromium.org/1014503005/diff/1/content/test/gpu/gpu_tests/gpu_rasterization_expectations.py#newcode13 content/test/gpu/gpu_tests/gpu_rasterization_expectations.py:13: # ...
5 years, 9 months ago (2015-03-16 18:41:25 UTC) #3
ccameron (do not use)
Thanks-- passes locally now. https://codereview.chromium.org/1014503005/diff/1/content/test/gpu/gpu_tests/gpu_rasterization_expectations.py File content/test/gpu/gpu_tests/gpu_rasterization_expectations.py (right): https://codereview.chromium.org/1014503005/diff/1/content/test/gpu/gpu_tests/gpu_rasterization_expectations.py#newcode13 content/test/gpu/gpu_tests/gpu_rasterization_expectations.py:13: # ['mac', 'amd', ('nvidia', 0x1234)], ...
5 years, 9 months ago (2015-03-16 18:48:33 UTC) #5
Ken Russell (switch to Gerrit)
Thanks. LGTM
5 years, 9 months ago (2015-03-16 19:10:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014503005/20001
5 years, 9 months ago (2015-03-16 19:19:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 20:52:36 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 20:53:23 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/772e590605971ee9c165e4ffdfec844edaf017f8
Cr-Commit-Position: refs/heads/master@{#320789}

Powered by Google App Engine
This is Rietveld 408576698