Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1014473005: add SK_LEGACY_DRAWPICTURECALLBACK guard flag (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add SK_LEGACY_DRAWPICTURECALLBACK guard flag Used until chrome switches to the new skia api BUG= TBR=robertphilips@chromium.org Committed: https://crrev.com/c97047888c9e13602ee390c99fd78b05efe7bc26 Cr-Commit-Position: refs/heads/master@{#320830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
reed1
... so we can remove this flag from skia_for_chromium_defines.gypi
5 years, 9 months ago (2015-03-16 21:11:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014473005/1
5 years, 9 months ago (2015-03-16 21:11:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 00:29:49 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c97047888c9e13602ee390c99fd78b05efe7bc26 Cr-Commit-Position: refs/heads/master@{#320830}
5 years, 9 months ago (2015-03-17 00:30:27 UTC) #6
robertphillips
lgtm
5 years, 9 months ago (2015-03-17 13:13:00 UTC) #8
robertphillips1
5 years, 9 months ago (2015-03-17 13:15:42 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698