Issue 1014473003: Drop declarations without matching definitions from SVGPathUtilities.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1014473003: Drop declarations without matching definitions from SVGPathUtilities.h (Closed)

Created:
5 years, 9 months ago by fs

Modified:
5 years, 9 months ago

Reviewers:
pdr., Erik Dahlström (inactive), f(malita)

CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Drop declarations without matching definitions from SVGPathUtilities.h appendSVGPathByteStreamFromSVGPathSeg and buildStringFromSVGPathSegList lack corresponding definitions. Also drop related forward declarations and includes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191941

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -8 lines)			Patch
	M	Source/core/svg/SVGPathUtilities.h	View		1 chunk	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014473003/1

5 years, 9 months ago (2015-03-16 15:46:25 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-16 19:05:23 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191941

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages