Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: net/quic/congestion_control/tcp_cubic_sender_test.cc

Issue 1014433002: Land Recent QUIC Changes until 03/09/2015. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replaces_Perspective_enun_88006458
Patch Set: Rebase - added NET_EXPORT_PRIVATE to fix compiler error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/congestion_control/tcp_cubic_sender.cc ('k') | net/quic/crypto/crypto_protocol.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/congestion_control/tcp_cubic_sender_test.cc
diff --git a/net/quic/congestion_control/tcp_cubic_sender_test.cc b/net/quic/congestion_control/tcp_cubic_sender_test.cc
index 1baffb0bcdbd0333f843795656c71325a626ffc8..a5e70ef9cadcafc455ad7190f32d9d32b9b6f364 100644
--- a/net/quic/congestion_control/tcp_cubic_sender_test.cc
+++ b/net/quic/congestion_control/tcp_cubic_sender_test.cc
@@ -494,7 +494,7 @@ TEST_F(TcpCubicSenderTest, DontTrackAckPackets) {
HAS_RETRANSMITTABLE_DATA));
}
-TEST_F(TcpCubicSenderTest, ConfigureMaxInitialWindow) {
+TEST_F(TcpCubicSenderTest, ConfigureInitialWindow) {
QuicConfig config;
// Verify that kCOPT: kIW10 forces the congestion window to the default of 10.
@@ -506,6 +506,19 @@ TEST_F(TcpCubicSenderTest, ConfigureMaxInitialWindow) {
EXPECT_EQ(10u, sender_->congestion_window());
}
+TEST_F(TcpCubicSenderTest, ConfigureMinimumWindow) {
+ QuicConfig config;
+
+ // Verify that kCOPT: kMIN1 forces the min CWND to 1 packet.
+ QuicTagVector options;
+ options.push_back(kMIN1);
+ QuicConfigPeer::SetReceivedConnectionOptions(&config, options);
+ sender_->SetFromConfig(config, Perspective::IS_SERVER,
+ /* using_pacing= */ false);
+ sender_->OnRetransmissionTimeout(true);
+ EXPECT_EQ(1u, sender_->congestion_window());
+}
+
TEST_F(TcpCubicSenderTest, DisableAckTrainDetectionWithPacing) {
EXPECT_TRUE(sender_->hybrid_slow_start().ack_train_detection());
« no previous file with comments | « net/quic/congestion_control/tcp_cubic_sender.cc ('k') | net/quic/crypto/crypto_protocol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698