Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 101443002: IDL compiler: remove redundant '_name' from template parameters (Closed)

Created:
7 years ago by Nils Barth (inactive)
Modified:
7 years ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

IDL compiler: remove redundant '_name' from template parameters '_name' is redundant in template parameter names (it's just string substitution), so this removes it, primarily simplifying: {{cpp_class_name}} => {{cpp_class}} {{v8_class_name}} => {{v8_class}} This helps readability a lot, as these are really common. (Discussed previously.) BUG=239771 NOTRY=true TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -138 lines) Patch
M Source/bindings/scripts/unstable/v8_attributes.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_callback_interface.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_interface.py View 7 chunks +6 lines, -7 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_methods.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M Source/bindings/templates/callback_interface.h View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/templates/callback_interface.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/templates/interface.h View 4 chunks +29 lines, -29 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 23 chunks +55 lines, -55 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 6 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
7 years ago (2013-12-03 09:09:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/101443002/1
7 years ago (2013-12-03 09:09:48 UTC) #2
haraken
LGTM. Being consistent is a good thing.
7 years ago (2013-12-03 09:10:22 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-03 09:13:48 UTC) #4
Message was sent while issue was closed.
Change committed as 163073

Powered by Google App Engine
This is Rietveld 408576698