Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 1014403002: [DevTools] Emulation domain implementation (browser side). (Closed)

Created:
5 years, 9 months ago by dgozman
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Emulation domain implementation (browser side). BUG=467059 Committed: https://crrev.com/23ca53245b79c816a5bc0e969a5b3393107fffdd Cr-Commit-Position: refs/heads/master@{#321339}

Patch Set 1 #

Patch Set 2 : nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -13 lines) Patch
M content/browser/devtools/protocol/emulation_handler.h View 2 chunks +29 lines, -5 lines 0 comments Download
M content/browser/devtools/protocol/emulation_handler.cc View 1 chunk +179 lines, -8 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.h View 3 chunks +9 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 1 4 chunks +11 lines, -0 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 6 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please.
5 years, 9 months ago (2015-03-18 16:45:56 UTC) #2
pfeldman
lgtm
5 years, 9 months ago (2015-03-19 11:06:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014403002/20001
5 years, 9 months ago (2015-03-19 11:06:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 12:26:23 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 12:26:56 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/23ca53245b79c816a5bc0e969a5b3393107fffdd
Cr-Commit-Position: refs/heads/master@{#321339}

Powered by Google App Engine
This is Rietveld 408576698