Issue 1014393002: Import BUILD.gn into ICU repo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1014393002: Import BUILD.gn into ICU repo (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 9 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/deps/icu/@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Import BUILD.gn into ICU repo BUG=none R=dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/d319ad9e25e8045f051dcd30bd5835f99936af6c

Patch Set 1 #

Patch Set 2 : updates #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+570 lines, -0 lines)			Patch
	A	BUILD.gn	View		1 chunk	+554 lines, -0 lines	0 comments	Download
	A	config.gni	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

lgtm assuming this is a straight copy over from chromium.

5 years, 9 months ago (2015-03-18 18:49:05 UTC) #2

jochen (gone - plz use gerrit)

Committed patchset #2 (id:20001) manually as d319ad9e25e8045f051dcd30bd5835f99936af6c (presubmit successful).

5 years, 9 months ago (2015-03-19 09:44:52 UTC) #3

jungshik at Google

5 years, 9 months ago (2015-03-19 19:07:03 UTC) #4

Message was sent while issue was closed.

On 2015/03/19 09:44:52, jochen (slow) wrote:
> Committed patchset #2 (id:20001) manually as
> d319ad9e25e8045f051dcd30bd5835f99936af6c (presubmit successful).

Thank you for this CL. I meant to do this, but you beat me to that :-)

Expand Messages | Collapse Messages