Teach cc::LayerTreeSettings to produce cc::SchedulerSettings

Teach cc::LayerTreeSettings to produce cc::SchedulerSettings

The cc::Proxy implementations need to translate their configuration as
represented by a cc::LayerTreeSettings object into a
cc::SchedulerSettings for the scheduler to consume. This was
accomplished by having cc::SchedulerSettings know how to construct
itself from a cc::LayerTreeSettings instance, but this was awkward since
it meant that cc/scheduler/ needed to depend on cc/trees/ in order to
accomplish a task only needed by cc/trees/. Logically the scheduler is
at a lower layer than the proxies. This inverts the dependency by
teaching LayerTreeSettings how to construct a SchedulerSettings object
with only the relevant fields.

R=danakj@chromium.org

Committed: https://crrev.com/6f64ab70b91993b75a54f953fdd1dfae4ed976dc
Cr-Commit-Position: refs/heads/master@{#321198}

[jamesr, 2015-03-18 17:45:11]

https://codereview.chromium.org/1014363004/diff/1/cc/trees/layer_tree_settings.h
File cc/trees/layer_tree_settings.h (right):

https://codereview.chromium.org/1014363004/diff/1/cc/trees/layer_tree_setting...
cc/trees/layer_tree_settings.h:23: RendererSettings renderer_settings;
another option would be to have SchedulerSettings work like this and be an
embedded struct instead of duplicating members, but there is a bit of
translation done (i.e. the fields on SchedulerSettings aren't identical to those
on LayerTreeSettings) and it would require consumers of LayerTreeSettings
outside of cc/ to care about which things are scheduler settings vs layer tree
settings when they probably don't care

[danakj, 2015-03-18 18:40:49]

LGTM

[enne (OOO), 2015-03-18 19:30:20]

lgtm

This was my fault originally.  It used to be a bunch of duplicated code that
translated from LayerTreeSettings to SchedulerSettings, so I just added a
function for it, but this is way better.

[jamesr, 2015-03-18 19:41:46]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2015-03-18 19:42:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1014363004/1

[commit-bot: I haz the power, 2015-03-18 20:29:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-18 20:30:04]

Patchset 1 (id:??) landed as
https://crrev.com/6f64ab70b91993b75a54f953fdd1dfae4ed976dc
Cr-Commit-Position: refs/heads/master@{#321198}

[brianderson, 2015-03-19 02:07:09]

brianderson@chromium.org changed reviewers:
+ brianderson@chromium.org

[brianderson, 2015-03-19 02:07:10]

lgtm! Thanks for the cleanup.

https://codereview.chromium.org/1014363004/diff/1/cc/scheduler/scheduler_sett...
File cc/scheduler/scheduler_settings.h (right):

https://codereview.chromium.org/1014363004/diff/1/cc/scheduler/scheduler_sett...
cc/scheduler/scheduler_settings.h:20: class LayerTreeSettings;
Can this be removed?

[jamesr, 2015-03-19 18:18:23]

On 2015/03/19 02:07:10, brianderson wrote:
> lgtm! Thanks for the cleanup.
> 
>
https://codereview.chromium.org/1014363004/diff/1/cc/scheduler/scheduler_sett...
> File cc/scheduler/scheduler_settings.h (right):
> 
>
https://codereview.chromium.org/1014363004/diff/1/cc/scheduler/scheduler_sett...
> cc/scheduler/scheduler_settings.h:20: class LayerTreeSettings;
> Can this be removed?

Oh, yes: https://codereview.chromium.org/1024593002