Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 101433002: Add a UseCounter for HTMLHeadElement.profile (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Add a UseCounter for HTMLHeadElement.profile http://whatwg.org/html#htmlheadelement The profile attribute is not in the spec and not supported by Opera 12.16 or Firefox Nightly. It is supported by IE11 Release Preview. Add a counter to see if we can remove it. IE11 reflects null as 'null', not '', but leave that for now. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163097

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLHeadElement.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
7 years ago (2013-12-03 10:03:07 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-12-03 11:21:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/101433002/1
7 years ago (2013-12-03 11:56:22 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-03 11:56:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/101433002/20001
7 years ago (2013-12-03 14:26:32 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-03 16:44:04 UTC) #6
Message was sent while issue was closed.
Change committed as 163097

Powered by Google App Engine
This is Rietveld 408576698