Chromium Code Reviews

Issue 1014293002: MIPS: Remove PropertyCell space. (Closed)

Created:
5 years, 9 months ago by balazs.kilvady
Modified:
5 years, 9 months ago
Reviewers:
dusmil.imgtec, danno, Toon Verwaest, paul.l..., gergely.kis.imgtec, akos.palfi.imgtec
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Remove PropertyCell space. Port 16c8485a35efc36cf6ccd15185282d65412e1502 Original commit message: Replaces StoreGlobalCell / LoadGlobalCell with NamedField variants that use write barriers. BUG= Committed: https://crrev.com/6142c7f8726bdf4a4ebc6246d7a18b1c9961c5b6 Cr-Commit-Position: refs/heads/master@{#27277}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+0 lines, -157 lines)
M src/mips/lithium-codegen-mips.cc View 2 chunks +0 lines, -37 lines 0 comments
M src/mips/lithium-mips.h View 4 chunks +0 lines, -24 lines 0 comments
M src/mips/lithium-mips.cc View 2 chunks +0 lines, -18 lines 0 comments
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +0 lines, -36 lines 0 comments
M src/mips64/lithium-mips64.h View 4 chunks +0 lines, -24 lines 0 comments
M src/mips64/lithium-mips64.cc View 2 chunks +0 lines, -18 lines 0 comments

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 9 months ago (2015-03-18 12:57:43 UTC) #2
dusmil.imgtec
lgtm.
5 years, 9 months ago (2015-03-18 14:31:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014293002/1
5 years, 9 months ago (2015-03-18 15:36:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 16:05:26 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 16:05:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6142c7f8726bdf4a4ebc6246d7a18b1c9961c5b6
Cr-Commit-Position: refs/heads/master@{#27277}

Powered by Google App Engine