Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1014263002: Allow compaction when incremental marking is on. (Closed)

Created:
5 years, 9 months ago by ulan
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow compaction when incremental marking is on. BUG=chromium:450824 LOG=NO Committed: https://crrev.com/92f96e4e9a527fcb085b68f81ee14b26acdd4719 Cr-Commit-Position: refs/heads/master@{#27267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M src/heap/incremental-marking.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/heap/incremental-marking.cc View 5 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ulan
PTAL
5 years, 9 months ago (2015-03-18 09:46:33 UTC) #2
Hannes Payer (out of office)
yes please, LGTM
5 years, 9 months ago (2015-03-18 09:56:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014263002/1
5 years, 9 months ago (2015-03-18 10:40:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 11:41:32 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/92f96e4e9a527fcb085b68f81ee14b26acdd4719 Cr-Commit-Position: refs/heads/master@{#27267}
5 years, 9 months ago (2015-03-18 11:41:39 UTC) #7
Igor Sheludko
5 years, 9 months ago (2015-03-20 16:06:34 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1026813002/ by ishell@chromium.org.

The reason for reverting is: It seems to cause crbug/469146..

Powered by Google App Engine
This is Rietveld 408576698