Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: LayoutTests/fast/dom/domstring-attribute-reflection.html

Issue 101423002: Remove TreatNullAs=NullString for HTMLTextAreaElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase on top of HTMLSelectElement patch Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/dom/domstring-attribute-reflection-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/dom/domstring-attribute-reflection.html
diff --git a/LayoutTests/fast/dom/domstring-attribute-reflection.html b/LayoutTests/fast/dom/domstring-attribute-reflection.html
index 6c6b897ad34651655fc665e81602ed75e973ecb1..afc1d97d235b17a1df87c53964047c8760121591 100644
--- a/LayoutTests/fast/dom/domstring-attribute-reflection.html
+++ b/LayoutTests/fast/dom/domstring-attribute-reflection.html
@@ -5,7 +5,7 @@
<script>
var element;
-function testDOMStringReflection(elementName, contentAttributeName, idlAttributeName, treatNullAsString) {
+function testDOMStringReflection(elementName, contentAttributeName, idlAttributeName) {
idlAttributeName = idlAttributeName || contentAttributeName;
element = document.createElement(elementName);
debug('Reflected DOMString attribute test for ' + elementName + '/@' + contentAttributeName);
@@ -22,13 +22,8 @@ function testDOMStringReflection(elementName, contentAttributeName, idlAttribute
shouldBeEqualToString('element.getAttribute("' + contentAttributeName + '")', ' bar\n');
debug('Setting null via the IDL attribute:');
- if (treatNullAsString) {
- shouldBeEqualToString('element.' + idlAttributeName + ' = null; element.' + idlAttributeName, 'null');
- shouldBeEqualToString('element.getAttribute("' + contentAttributeName + '")', 'null');
- } else {
- shouldBeEqualToString('element.' + idlAttributeName + ' = null; element.' + idlAttributeName, '');
- shouldBeNull('element.getAttribute("' + contentAttributeName + '")');
- }
+ shouldBeEqualToString('element.' + idlAttributeName + ' = null; element.' + idlAttributeName, 'null');
+ shouldBeEqualToString('element.getAttribute("' + contentAttributeName + '")', 'null');
debug('Setting null via the content attribute:');
shouldBeEqualToString('element.setAttribute("' + contentAttributeName + '", null); element.' + idlAttributeName, 'null');
@@ -53,15 +48,15 @@ function testDOMStringReflection(elementName, contentAttributeName, idlAttribute
debug('\n');
}
-testDOMStringReflection('button', 'name', 'name', true);
-testDOMStringReflection('fieldset', 'name', 'name', true);
-testDOMStringReflection('form', 'name', 'name', true);
-testDOMStringReflection('input', 'name', 'name', true);
-testDOMStringReflection('input', 'step', 'step', true);
-testDOMStringReflection('keygen', 'name', 'name', true);
-testDOMStringReflection('object', 'name', 'name', true);
-testDOMStringReflection('output', 'name', 'name', true);
-testDOMStringReflection('select', 'name', 'name', true);
+testDOMStringReflection('button', 'name');
+testDOMStringReflection('fieldset', 'name');
+testDOMStringReflection('form', 'name');
+testDOMStringReflection('input', 'name');
+testDOMStringReflection('input', 'step');
+testDOMStringReflection('keygen', 'name');
+testDOMStringReflection('object', 'name');
+testDOMStringReflection('output', 'name');
+testDOMStringReflection('select', 'name');
testDOMStringReflection('textarea', 'name');
// Add more DOMString attributes!
« no previous file with comments | « no previous file | LayoutTests/fast/dom/domstring-attribute-reflection-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698