Issue 101423002: Remove TreatNullAs=NullString for HTMLTextAreaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101423002: Remove TreatNullAs=NullString for HTMLTextAreaElement (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove TreatNullAs=NullString for HTMLTextAreaElement http://whatwg.org/html#htmltextareaelement The value attribute has [TreatNullAs=EmptyString] in the spec. The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: Firefox does not support dirName or inputMode. IE does not support dirName or inputMode, reflects value as 'null', and throws an exception for wrap. Opera does not support inputMode. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163094

Patch Set 1 #

Patch Set 2 : update test #

Patch Set 3 : rebase on top of HTMLSelectElement patch #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -34 lines)			Patch
M	LayoutTests/fast/dom/domstring-attribute-reflection.html	View	1 2	3 chunks	+12 lines, -17 lines	0 comments	Download
M	LayoutTests/fast/dom/domstring-attribute-reflection-expected.txt	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/element-attribute-js-null.html	View	1 2	1 chunk	+7 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/dom/element-attribute-js-null-expected.txt	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/forms/textarea/textarea-inputmode.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/forms/textarea/textarea-inputmode-expected.txt	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLTextAreaElement.idl	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

Depends on https://codereview.chromium.org/101573002/ due to conflicts. See patch set 2 for trybot success.

7 years ago (2013-12-03 11:58:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/101423002/40001

7 years ago (2013-12-03 14:20:39 UTC) #3

Message was sent while issue was closed.

Change committed as 163094

Expand Messages | Collapse Messages