chrome/browser/speech/tts_controller.h - Issue 1014143003: Change set_continuous_parameters() for removing duplicated behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/tts_controller.h

Issue 1014143003: Change set_continuous_parameters() for removing duplicated behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/speech/extension_api/tts_extension_api.cc ('k') | chrome/browser/speech/tts_message_filter.cc » ('j') | chrome/browser/speech/tts_message_filter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/tts_controller.h

diff --git a/chrome/browser/speech/tts_controller.h b/chrome/browser/speech/tts_controller.h

index 8f32cd93c152b47125a7bc6751e541088fba41db..64845a935e1d5d21b673d084bab15d8a21912722 100644

--- a/chrome/browser/speech/tts_controller.h

+++ b/chrome/browser/speech/tts_controller.h

@@ -172,8 +172,12 @@ class Utterance {

}

TtsGenderType gender() const { return gender_; }

- void set_continuous_parameters(const UtteranceContinuousParameters& params) {

- continuous_parameters_ = params;

+ void set_continuous_parameters(const double rate,

+ const double pitch,

dmazzoni 2015/03/30 16:04:11 Fix the indentation

deejay 2015/03/30 16:29:45 Done.

+ const double volume) {

+ continuous_parameters_.rate = rate;

+ continuous_parameters_.pitch = pitch;

+ continuous_parameters_.volume = volume;

}

const UtteranceContinuousParameters& continuous_parameters() {

return continuous_parameters_;