Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1014143003: Change set_continuous_parameters() for removing duplicated behavior. (Closed)

Created:
5 years, 9 months ago by deejay
Modified:
5 years, 8 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UtteranceContinuousParameters was created twice in utterance. It is an unnecessary behavior and we need to remove this. BUG=463264 Committed: https://crrev.com/61eb0c22c8e646689877583db9ef19c6380ca97c Cr-Commit-Position: refs/heads/master@{#322805}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix indentation #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M chrome/browser/speech/extension_api/tts_extension_api.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/speech/tts_controller.h View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/speech/tts_message_filter.cc View 1 2 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
deejay
Hi Dominic, This patch changes to set_continuous_parameters() for removing duplicated behavior. Please take a look ...
5 years, 9 months ago (2015-03-26 10:23:18 UTC) #2
deejay
PTAL.
5 years, 9 months ago (2015-03-28 07:59:05 UTC) #4
deejay
On 2015/03/28 07:59:05, deejay wrote: > PTAL. Ping. Dear Dominic, David Tseng. Could you review ...
5 years, 8 months ago (2015-03-30 14:04:30 UTC) #5
dmazzoni
lgtm https://codereview.chromium.org/1014143003/diff/1/chrome/browser/speech/tts_controller.h File chrome/browser/speech/tts_controller.h (right): https://codereview.chromium.org/1014143003/diff/1/chrome/browser/speech/tts_controller.h#newcode176 chrome/browser/speech/tts_controller.h:176: const double pitch, Fix the indentation https://codereview.chromium.org/1014143003/diff/1/chrome/browser/speech/tts_message_filter.cc File ...
5 years, 8 months ago (2015-03-30 16:04:12 UTC) #6
deejay
I've updated with fixing indentation. Please take a look. https://codereview.chromium.org/1014143003/diff/1/chrome/browser/speech/tts_controller.h File chrome/browser/speech/tts_controller.h (right): https://codereview.chromium.org/1014143003/diff/1/chrome/browser/speech/tts_controller.h#newcode176 chrome/browser/speech/tts_controller.h:176: ...
5 years, 8 months ago (2015-03-30 16:29:45 UTC) #7
dmazzoni
lgtm
5 years, 8 months ago (2015-03-30 16:36:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014143003/40001
5 years, 8 months ago (2015-03-30 16:36:59 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-03-30 17:38:45 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 17:41:40 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/61eb0c22c8e646689877583db9ef19c6380ca97c
Cr-Commit-Position: refs/heads/master@{#322805}

Powered by Google App Engine
This is Rietveld 408576698